[Cases] Remove alerts from cases #143457
[Cases] Remove alerts from cases #143457
Conversation
cnasikas
added
backport:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
| const { comment } = userAction.payload; | ||
|
|
||
| if (comment.type === CommentType.alert) { | ||
| const alertLabel = |
There was a problem hiding this comment.
Just curious, would it be better to use a single translation for this? I suppose we'd need to force comment.alertId to be an array for that to work though. I believe the translations can handle the plural vs singular.
| <UserCommentPropertyActions | ||
| isLoading={isLoading} | ||
| commentContent={comment.comment} | ||
| onEdit={() => handleManageMarkdownEditId(comment.id)} |
There was a problem hiding this comment.
Just a note, this will recreate the anonymous function on each render, is it worth creating a useCallback for these? Probably not that much of a performance improvement though
There was a problem hiding this comment.
Unfortunately, this is not a hook so I cannot use useCallback. I need to create another component that wraps the actions so I can use useCallback. Do you mind if we leave it as it is and do the performance improvement if needed?
There was a problem hiding this comment.
Yeah that's fine, leave it as it is.
| const builderArgs = getMockBuilderArgs(); | ||
|
|
||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('renders correctly a description', async () => { |
There was a problem hiding this comment.
nit: there's an extra space between correctly and a
|
For a user with read only access to Cases, the actions popover menu is shown, but is empty. We should hide this if there are no actions:
|
|
@peteharverson Fixed in 7a9fec0 |
cnasikas
force-pushed
the
unlink_alerts_comments
branch
from
790a691
to
7a9fec0
Compare
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @cnasikas |
* Remove alerts from cases * Refactor property actions * Add tests * Fix i18n * Fix tests * PR feedback * Do not show property action if empty Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR allows users to remove alerts from a case through the case activity. It also:
Screenshots
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release notes
Add the ability to remove alerts attached to a case