Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the max length limit of the case title to 160 characters #143664

Merged
merged 4 commits into from Oct 24, 2022
Merged

Increase the max length limit of the case title to 160 characters #143664

merged 4 commits into from Oct 24, 2022

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Oct 19, 2022 •
edited

Summary

  • Changed the max length allowed for the case title.
  • Changed the width of the Name(title) column in the cases table. It better fits long titles now can be seen in the screenshots below.
  • Increased the width of the Select case modal in alerts.

Screenshots

Old width:
old width

New width:
new width

Old modal:
modal l

New modal:
modal xl

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Fixes #142232

Release notes

Increases the max length limit of the case title to 160 characters

@adcoelho adcoelho added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Oct 19, 2022
@adcoelho adcoelho requested a review from a team as a code owner October 19, 2022 14:32
@adcoelho adcoelho self-assigned this Oct 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@jonathan-buttner jonathan-buttner added release_note:enhancement v8.6.0 backport:skip This commit does not require backporting labels Oct 19, 2022
@adcoelho adcoelho force-pushed the increase-max-length-case-title branch 3 times, most recently from e8b1e9c to ae192fa Compare October 20, 2022 13:54
@adcoelho adcoelho force-pushed the increase-max-length-case-title branch from ae192fa to 3b658e7 Compare October 24, 2022 08:40
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 372.9KB 372.9KB +14.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 126.1KB 126.1KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

cnasikas
cnasikas approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀. Code LGTM! Tested without issues.

@cnasikas cnasikas mentioned this pull request Oct 24, 2022
Closed
@cnasikas cnasikas linked an issue Oct 24, 2022 that may be closed by this pull request
[Security Solution] [Cases] External incident description is close to the Select button #119860
Closed
@adcoelho adcoelho merged commit b31c1d6 into elastic:main Oct 24, 2022
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Oct 24, 2022
@adcoelho @jennypavlova
Increase the max length limit of the case title to 160 characters (el…
d63a680 
…astic#143664)

* Changed MAX_TITLE_LENGTH; fixed column width for case title.

* Updated tests with the new case title max length.

* Updated snapshots to fix failing tests.

* Increased the width of the select case modal in alerts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@adcoelho adcoelho

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Milestone
No milestone
5 participants
@adcoelho @elasticmachine @kibana-ci @cnasikas @jonathan-buttner