Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Visualize] Hides the unused dimension label from the tooltip #143721

Merged

Conversation

stratoula
Copy link
Contributor

Summary

Closes #143626

It hides the unnecessary dimension from the tooltip

Missing X axis
image

Missing Y axis
image

I can't find any regression by applying this change but I'd appreciate another pair of 👁️

@stratoula stratoula added Feature:Heatmap Heatmap visualization release_note:fix Feature:Lens backport:skip This commit does not require backporting v8.6.0 labels Oct 20, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionHeatmap 91.3KB 91.3KB +12.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review October 20, 2022 08:10
@stratoula stratoula requested a review from a team as a code owner October 20, 2022 08:10
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine, LGTM

@stratoula stratoula merged commit eaf4e5c into elastic:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Heatmap Heatmap visualization Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Tooltip displays empty value in tooltip for non-exists vertical column for heatmap
4 participants