-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy #144105
[Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy #144105
Conversation
…from policies page
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, it's definitely an improvement 👍
<EuiText> | ||
<FormattedMessage | ||
id="xpack.fleet.agentEnrollment.instructionstFleetServer" | ||
defaultMessage="A Fleet Server is required before you can enroll agents with Fleet. Follow the instructions below to set up a Fleet Server. For more information, see the {userGuideLink}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user might have a fleet server already set up, does this make it sound like they haven't and they need to add one to add an agent? We might want to get DeDe to review this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the same copy that we use in the Add Fleet Server
here, it probably had some unnecessary complexity (in my opinion) to add a specific copy if there is already a Fleet Server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep agreed 👌
...ck/plugins/fleet/public/applications/fleet/sections/agent_policy/components/actions_menu.tsx
Outdated
Show resolved
Hide resolved
…policy/components/actions_menu.tsx
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
* main: (41 commits) [api-docs] Daily api_docs build (elastic#144212) Add readonly view to role management (elastic#143893) [api-docs] Daily api_docs build (elastic#144208) [APM] Adds button group to navigate to "All services" (elastic#142911) Update react-query to ^4.12.0 (main) (elastic#139986) [APM] Support specific fields when creating service groups (elastic#142201) (elastic#143881) [api-docs] Daily api_docs build (elastic#144203) [ts] add stub index.d.ts in @kbn/ui-shared-deps-npm [Synthetics] Fix failing Synthetics Integration test (elastic#144175) chore(NA): remove @types/pkg link creation when generating a new package (elastic#144200) [Osquery] Update schema to v5.5.1 (elastic#144090) [ci] remove github-checks-reporter (elastic#144193) [8.6][ML Inference] Verify pipeline usage before deletion (elastic#144053) [ts] ts refs cache was removed, remove capture task Added Rollups CCS Test (elastic#144074) [auto] migrate existing plugin/package configs [ts] stop building @types packages in bootstrap skip failing test suite (elastic#142762) skip failing test suite (elastic#144186) [Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy (elastic#144105) ...
Description
Resolve #143519
@hop-dev @kpollich I am curious to get your thoughts on this as a potential solution to #143519
The behavior seen in #143519 was not totally incorrect as the Add agent Flyout allow to add a Fleet server so that PR make some changes to the add agent Flyout to use
Add Fleet Server
and update the copy when trying to add a Fleet server.UI Changes