Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Adds maxRetries:0 to relevant API calls. #144603

Merged
merged 3 commits into from Nov 7, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Nov 4, 2022

Summary

Fixes #144592.

Adds { maxRetries: 0 } to some transform related API calls (esp. preview) to avoid performance problem in case of retries.

/cc @droberts195

Checklist

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@walterra walterra added bug Fixes for quality problems that affect the customer experience release_note:fix labels Nov 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit acf3895 into elastic:main Nov 7, 2022
@walterra walterra deleted the ml-transform-preview-max-retries-0 branch November 7, 2022 10:02
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 7, 2022
Adds { maxRetries: 0 } to some transform related API calls (esp. preview) to avoid performance problem in case of retries.

(cherry picked from commit acf3895)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 144603

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 7, 2022
Adds { maxRetries: 0 } to some transform related API calls (esp. preview) to avoid performance problem in case of retries.

(cherry picked from commit acf3895)

Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
@walterra
Copy link
Contributor Author

walterra commented Nov 7, 2022

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

walterra added a commit to walterra/kibana that referenced this pull request Nov 7, 2022
Adds { maxRetries: 0 } to some transform related API calls (esp. preview) to avoid performance problem in case of retries.

(cherry picked from commit acf3895)

# Conflicts:
#	x-pack/plugins/transform/server/routes/api/transforms.ts
walterra added a commit that referenced this pull request Nov 7, 2022
Adds { maxRetries: 0 } to some transform related API calls (esp. preview) to avoid performance problem in case of retries.

(cherry picked from commit acf3895)

# Conflicts:
#	x-pack/plugins/transform/server/routes/api/transforms.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml release_note:fix v7.17.8 v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Transforms: Don't auto-retry transform previews if a response isn't received
6 participants