Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time for logs smoke tests in integration test #145130

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Nov 14, 2022

Trying to fix this error in logs smoke test in integration by setting time to

await PageObjects.timePicker.setCommonlyUsedTime('Last_1 year');
13:59:32 78 passing (30.0m)
13:59:32 2 failing
13:59:32 
13:59:32 1)    upgrade
13:59:32        upgrade logs smoke tests
13:59:32          space: default
13:59:32            should show log streams:
13:59:32 
13:59:32       Error: expected 2 to be above 100
13:59:32        at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
13:59:32        at Assertion.greaterThan.Assertion.above (node_modules/@kbn/expect/expect.js:317:8)
13:59:32        at Function.greaterThan (node_modules/@kbn/expect/expect.js:531:15)
13:59:32        at Context.<anonymous> (x-pack/test/upgrade/apps/logs/logs_smoke_tests.ts:34:49)
13:59:32        at runMicrotasks (<anonymous>)
13:59:32        at processTicksAndRejections (node:internal/process/task_queues:96:5)
13:59:32        at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
13:59:32  
13:59:32  
13:59:32 2)    upgrade
13:59:32        upgrade logs smoke tests
13:59:32          space: automation
13:59:32            should show log streams:
13:59:32 
13:59:32       Error: expected 2 to be above 100
13:59:32        at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
13:59:32        at Assertion.greaterThan.Assertion.above (node_modules/@kbn/expect/expect.js:317:8)
13:59:32        at Function.greaterThan (node_modules/@kbn/expect/expect.js:531:15)
13:59:32        at Context.<anonymous> (x-pack/test/upgrade/apps/logs/logs_smoke_tests.ts:34:49)
13:59:32        at runMicrotasks (<anonymous>)
13:59:32        at processTicksAndRejections (node:internal/process/task_queues:96:5)
13:59:32        at Object.apply (node_modules/@kbn/test/target_node/src/functional_test_runner/lib/mocha/wrap_function.js:78:16)
13:59:32  
13:59:32  
13:59:32 

@bhavyarm bhavyarm self-assigned this Nov 14, 2022
@bhavyarm bhavyarm added v8.6.0 release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Nov 14, 2022
@bhavyarm bhavyarm marked this pull request as ready for review November 14, 2022 19:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm bhavyarm requested a review from LeeDr November 14, 2022 19:28
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@LeeDr LeeDr requested a review from liza-mae November 14, 2022 20:40
Copy link
Contributor

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - This is the same change and for the same reason as the change in x-pack/test/upgrade/apps/discover/discover_smoke_tests.ts. Besides the Cloud testing which all happens sequentially, we're now also running these tests "on-prem" and using an Elasticsearch snapshot of the earlier version.

@bhavyarm bhavyarm merged commit fdfeda4 into elastic:main Nov 14, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 14, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 14, 2022
…45183)

# Backport

This will backport the following commits from `main` to `8.5`:
- [Fix time for logs smoke tests in integration test
(#145130)](#145130)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bhavya
RM","email":"bhavya@elastic.co"},"sourceCommit":{"committedDate":"2022-11-14T20:49:47Z","message":"Fix
time for logs smoke tests in integration test
(#145130)","sha":"fdfeda4192df7c2129573cf53c761a3cab752884","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","release_note:skip","backport:prev-minor","v8.6.0"],"number":145130,"url":"#145130
time for logs smoke tests in integration test
(#145130)","sha":"fdfeda4192df7c2129573cf53c761a3cab752884"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"#145130
time for logs smoke tests in integration test
(#145130)","sha":"fdfeda4192df7c2129573cf53c761a3cab752884"}}]}]
BACKPORT-->

Co-authored-by: Bhavya RM <bhavya@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2022
* main: (65 commits)
  Migrate server-side `Root` and `Server` to packages (elastic#144990)
  [Discover] Handle no data views state for `esQuery` alert (elastic#145052)
  [ML] Allow updates for number of allocations and priority for trained model deployments (elastic#144704)
  [api-docs] 2022-11-15 Daily api_docs build (elastic#145203)
  [Security solution] remove guided onboarding feature flag (elastic#144247)
  [DOCS] Automate final case APIs (elastic#145007)
  [Enterprise Search] Name and description flyout for connectors (elastic#143827)
  [Guided onboarding] Update header button logic (elastic#144634)
  [Lens] Multi metric partition charts (elastic#143966)
  [Dashboard] [Controls] Add unmapped runtime field support to options list (elastic#144947)
  [Security Solution] Add Task Metric Collection to New Tasks (elastic#145181)
  [TriggersActionsUi] disable jest config in CI (elastic#145186)
  [TableListView] Enhance tag filtering (elastic#142108)
  [Cloud Posture] Compliance by CIS section table (elastic#145114)
  [8.6][Session View] Fix hidden alert flyout  in session view (elastic#145141)
  [customIntegrations] async load all components (elastic#145166)
  Fix time for logs smoke tests in integration test (elastic#145130)
  [RAM] Update rule status (elastic#140882)
  Update babel (main) (elastic#145060)
  [Actionable Observability] Add context.alertDetailsUrl variable to action connector template for APM rule types (elastic#144791)
  ...
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants