[ML] Data Frame Analytics maps view: ensure nodes reload correctly after using timepicker refresh #145265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:fix
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
changed the title
alvarezmelissa87
changed the title
|
@elasticmachine merge upstream |
walterra
approved these changes
Nov 17, 2022
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2022
…ter using timepicker refresh (elastic#145265) ## Summary Fixes elastic#144308 This PR adds tracking of node ids that have been used to fetch additional node data so that, on refresh, the data for these nodes is also refetched. Before:  After: https://user-images.githubusercontent.com/6446462/201964406-39689a3c-76f9-4132-ad62-5c2bccc17622.mp4 ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit baf450d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
…tly after using timepicker refresh (#145265) (#145607) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Data Frame Analytics maps view: ensure nodes reload correctly after using timepicker refresh (#145265)](#145265) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Melissa Alvarez","email":"melissa.alvarez@elastic.co"},"sourceCommit":{"committedDate":"2022-11-17T18:32:02Z","message":"[ML] Data Frame Analytics maps view: ensure nodes reload correctly after using timepicker refresh (#145265)\n\n## Summary\r\n\r\nFixes #144308 PR adds tracking of node ids that have been used to fetch\r\nadditional node data so that, on refresh, the data for these nodes is\r\nalso refetched.\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6446462/201964406-39689a3c-76f9-4132-ad62-5c2bccc17622.mp4\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"baf450ddde6726b9523e20519585caa002cd8197","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Data Frame Analytics","v8.6.0","v8.7.0"],"number":145265,"url":"#145265 Data Frame Analytics maps view: ensure nodes reload correctly after using timepicker refresh (#145265)\n\n## Summary\r\n\r\nFixes #144308 PR adds tracking of node ids that have been used to fetch\r\nadditional node data so that, on refresh, the data for these nodes is\r\nalso refetched.\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6446462/201964406-39689a3c-76f9-4132-ad62-5c2bccc17622.mp4\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"baf450ddde6726b9523e20519585caa002cd8197"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#145265 Data Frame Analytics maps view: ensure nodes reload correctly after using timepicker refresh (#145265)\n\n## Summary\r\n\r\nFixes #144308 PR adds tracking of node ids that have been used to fetch\r\nadditional node data so that, on refresh, the data for these nodes is\r\nalso refetched.\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6446462/201964406-39689a3c-76f9-4132-ad62-5c2bccc17622.mp4\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"baf450ddde6726b9523e20519585caa002cd8197"}}]}] BACKPORT--> Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
\r\n\r\nAfter:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6446462/201964406-39689a3c-76f9-4132-ad62-5c2bccc17622.mp4\r\n\r\n\r\n###){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #144308
This PR adds tracking of node ids that have been used to fetch additional node data so that, on refresh, the data for these nodes is also refetched.
Before:
After:
dfaMapFix.mp4
Checklist
Delete any items that are not applicable to this PR.