Returns all the saved queries on the list and not only the first 50 #145554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
release_note:fix
Team:Visualizations
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
drewdaemon
approved these changes
Nov 17, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2022
…lastic#145554) ## Summary Closes elastic#145551 This fixes the bug of the list only displaying the first 50 saved queries. It was using the wrong function. Now we are returning everything. (cherry picked from commit a67bfd1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2022
…t 50 (#145554) (#145679) # Backport This will backport the following commits from `main` to `8.6`: - [Returns all the saved queries on the list and not only the first 50 (#145554)](#145554) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2022-11-18T06:37:49Z","message":"Returns all the saved queries on the list and not only the first 50 (#145554)\n\n## Summary\r\n\r\nCloses #145551 fixes the bug of the list only displaying the first 50 saved\r\nqueries. It was using the wrong function. Now we are returning\r\neverything.","sha":"a67bfd10b2b66eb5277ce619487bbeee32f352bf","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Unified search","backport:prev-minor","v8.6.0","v8.7.0"],"number":145554,"url":"#145554 all the saved queries on the list and not only the first 50 (#145554)\n\n## Summary\r\n\r\nCloses #145551 fixes the bug of the list only displaying the first 50 saved\r\nqueries. It was using the wrong function. Now we are returning\r\neverything.","sha":"a67bfd10b2b66eb5277ce619487bbeee32f352bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#145554 all the saved queries on the list and not only the first 50 (#145554)\n\n## Summary\r\n\r\nCloses #145551 fixes the bug of the list only displaying the first 50 saved\r\nqueries. It was using the wrong function. Now we are returning\r\neverything.","sha":"a67bfd10b2b66eb5277ce619487bbeee32f352bf"}}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #145551
This fixes the bug of the list only displaying the first 50 saved queries. It was using the wrong function. Now we are returning everything.