[8.6] Catching saved object not found error, do not delete referenced package assets (#146274) #146411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge assets (elastic#146274) ## Summary Fixes elastic#142112 Improvements coming out of SDHs, to handle Fleet errors more robustly. ### 1. Catching package assets not found error and logging a warning, to prevent it blocking setup/install. ### 2. In assets cleanup logic, doing a check that the assets are not referenced by packages before deleting them. Verifying 1. and 2. hard, because I don't have a way to reproduce the assets not found error. Tried to install/delete different versions of a package, but didn't run into the issues. ### 3. Force removing a package deletes package policies as well To verify: - add at least one integration (e.g. system package) - force delete integration with API ``` DELETE http://elastic:changeme@localhost:5601/julia/api/fleet/epm/packages/system/1.20.4 kbn-xsrf: kibana { "force": true } ``` - verify that package policies are deleted as well - there is an info log added: ``` [2022-11-24T14:10:29.138+01:00][INFO ][plugins.fleet] deleting package policies of system package because force flag was enabled: 84a4e5d4-e363-4045-9240-9ab151f2b376,6d34a544-7467-48fd-a779-c2d30d808aa6 ``` ### 4. Catching saved object not found error when tagging package assets To verify: - follow the steps above to force delete a package - add system integration again - verify that it succeeds, and there is a warning log ``` [2022-11-24T14:07:47.960+01:00][WARN ][plugins.fleet] Error: Saved object [dashboard/system-01c54730-fee6-11e9-8405-516218e3d268] not found ``` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 7198faf)
botelastic
bot
added
the
Team:Fleet
1 task
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.6:Questions ?
Please refer to the Backport tool documentation