Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On Week][Global Experience] Generate Large Dataset #146816

Closed
wants to merge 20 commits into from

Conversation

majagrubic
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@majagrubic majagrubic changed the title On week large dataset [On Week] Generate Large Dataset Dec 1, 2022
@majagrubic majagrubic changed the title [On Week] Generate Large Dataset [On Week][Global Experience] Generate Large Dataset Dec 5, 2022
return `[${new Date().toLocaleTimeString()}]`;
}

export function createLogger(logLevel: LogLevel) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core now also offers a browser-side logger: #144107.

@majagrubic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@majagrubic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Creating "does not exist" query from first control filters the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Creating "exists" query from first control filters the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Excluding all options of first control removes all options in second and third controls

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
home 197 212 +15

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/home-sample-data-tab 2 6 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 153.9KB 168.6KB +14.7KB
Unknown metric groups

API count

id before after diff
@kbn/home-sample-data-tab 8 12 +4

async chunk count

id before after diff
home 3 5 +2

ESLint disabled line counts

id before after diff
@kbn/home-sample-data-tab 0 2 +2
home 10 18 +8
securitySolution 432 435 +3
total +13

miscellaneous assets size

id before after diff
home 398.3KB 499.6KB +101.3KB

Total ESLint disabled count

id before after diff
@kbn/home-sample-data-tab 0 2 +2
home 11 19 +8
securitySolution 512 515 +3
total +13

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @majagrubic @Dosant

@Dosant Dosant mentioned this pull request Apr 4, 2023
3 tasks
@legrego legrego closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants