Add groupByKeys context to recovered alerts for Log Threshold Rule and Metric Threshold Rule #146874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benakansara
added
backport:skip
benakansara
changed the title
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
| @@ -935,6 +940,7 @@ const processRecoveredAlerts = ({ | |||
| const baseContext = { | |||
| alertDetailsUrl: getAlertDetailsUrl(basePath, spaceId, alertUuid), | |||
| group: hasGroupBy(validatedParams) ? recoveredAlertId : null, | |||
| groupByKeys: groupByKeysObjectForRecovered[recoveredAlertId], | |||
There was a problem hiding this comment.
Just out of curiosity: Do we have a test to check what is generated in the context?
There was a problem hiding this comment.
I don't believe we have tests to check context of recovered alerts. I will add this in a separate PR.
smith
approved these changes
Dec 8, 2022
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
saarikabhasi
pushed a commit
to saarikabhasi/kibana
that referenced
this pull request
Dec 14, 2022
…d Metric Threshold Rule (elastic#146874) ## Summary Closes elastic#146349, elastic#146347 With this PR, it is possible to use `groupByKeys` context variable for `Recovered` action template when creating Log threshold and Metric threshold rules. Previously this context variable was available, but was not set for `recovered` alerts. When a Log/Metric Threshold rule is created with one or more `group by`, for example, `agent.hostname` and `container.id`, the `context.groupByKeys` variable will have an object of group by keys as below: ``` { "agent": { "hostname": "host-01" }, "container": { "id": "container-01" } } ``` Co-authored-by: Faisal Kanout <faisal.kanout@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #146349, #146347
With this PR, it is possible to use
groupByKeyscontext variable forRecoveredaction template when creating Log threshold and Metric threshold rules. Previously this context variable was available, but was not set forrecoveredalerts.When a Log/Metric Threshold rule is created with one or more
group by, for example,agent.hostnameandcontainer.id, thecontext.groupByKeysvariable will have an object of group by keys as below: