only show expand toggle, in view mode, on hover

[stacey-gammon]

They are distracting in view mode when they show up on every panel.

Before:

After:

[nreese]

lgtm - very nice. This really cleans up the dashboard look and feel

[cjcenizal]

LGTM! You're on a roll! 🔥

Have you also considered hiding the ContextMenu buttons when in edit mode, and revealing them on hover?

[stacey-gammon]

Have you also considered hiding the ContextMenu buttons when in edit mode, and revealing them on hover?

@cjcenizal , hmmm, I have not, until now. Do you think if I did that we'd need a way to visually indicate edit mode? With the new margins introduced, I got rid of the dashed borders. I could bring them back I suppose, but they are distracting IMO. Maybe we don't need an indication of view or edit mode?

[cjcenizal]

@stacey-gammon Oh I didn't notice the dashed borders are gone! I just took another look and I definitely think the old borders were ugly, so it's good that they're gone. But I do think that it's less clear when you're editing and when you're not because the dashboard looks almost identical in both modes.

We could solve this by tweaking the "edit" mode slightly. Here I've made the border-style "dotted", border-width 1px, and removed the box-shadow for edit mode:

Contrast against the view mode style:

Thoughts @stacey-gammon and @snide ?

In terms of my original suggestion, once the difference between view and edit mode is more clear I think we can make a better decision about whether hiding the context menu makes sense.

[stacey-gammon]

lgtm, if @snide has no objections, I'll go ahead and implement

[snide]

Good catch, though I think we'll need some more definition beyond the shadows. If we can wait, I'll spend a couple hours monday cleaning all this stuff up. There's a lot more easy fixes we can do in there.

[cjcenizal]

Works for me, thanks @snide!