Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Alerting] Failed test x-pack/plugins/triggers_actions_ui/public/application/lib/transformActionVariables #147579

Merged
merged 3 commits into from Dec 14, 2022
Merged

[ResponseOps][Alerting] Failed test x-pack/plugins/triggers_actions_ui/public/application/lib/transformActionVariables #147579

merged 3 commits into from Dec 14, 2022

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Dec 14, 2022 •
edited

Summary

Resolves #147573

Checklist

@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:fix labels Dec 14, 2022
@doakalexi doakalexi marked this pull request as ready for review December 14, 2022 20:53
@doakalexi doakalexi requested a review from a team as a code owner December 14, 2022 20:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI :)

@doakalexi doakalexi enabled auto-merge (squash) December 14, 2022 20:56
@tylersmalley
Copy link
Contributor

Thanks for addressing so quickly!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 445 451 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 521 527 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit 182c05e into elastic:main Dec 14, 2022
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Dec 14, 2022
@XavierM XavierM mentioned this pull request Dec 14, 2022
Merged
This was referenced Dec 15, 2022
Closed
Closed
Closed
Closed
Closed
Closed
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Dec 16, 2022
@doakalexi @crespocarlos
[ResponseOps][Alerting] Failed test x-pack/plugins/triggers_actions_u…
bb1d703 
…i/public/application/lib/transformActionVariables (elastic#147579)

## Summary

Resolves elastic#147573


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.7.0
Projects
None yet
Milestone
No milestone
6 participants
@doakalexi @elasticmachine @tylersmalley @kibana-ci @ymao1 @kibanamachine