[ML] Explain Log Rate Spikes: Fix mini histograms for groups with multiples values per field. #147597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
5 tasks
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
qn895
approved these changes
Dec 20, 2022
|
Code LGTM |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 20, 2022
…tiples values per field. (elastic#147597) For groups that have multiple values for the same field, the group histogram query wasn't able to fetch data because it filters with a bool `must` and individual `term` aggregations. This PR fixes it by using a `terms` aggregation if there are multiple values for a field so just these get treated as `OR`. (cherry picked from commit 3a48b7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 20, 2022
…th multiples values per field. (#147597) (#147865) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Explain Log Rate Spikes: Fix mini histograms for groups with multiples values per field. (#147597)](#147597) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2022-12-20T15:31:12Z","message":"[ML] Explain Log Rate Spikes: Fix mini histograms for groups with multiples values per field. (#147597)\n\nFor groups that have multiple values for the same field, the group\r\nhistogram query wasn't able to fetch data because it filters with a bool\r\n`must` and individual `term` aggregations. This PR fixes it by using a\r\n`terms` aggregation if there are multiple values for a field so just\r\nthese get treated as `OR`.","sha":"3a48b7a84e587f0d5b9bffef0abecbce9c62e2e6","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:ML/AIOps","v8.6.0","v8.7.0"],"number":147597,"url":"#147597 Explain Log Rate Spikes: Fix mini histograms for groups with multiples values per field. (#147597)\n\nFor groups that have multiple values for the same field, the group\r\nhistogram query wasn't able to fetch data because it filters with a bool\r\n`must` and individual `term` aggregations. This PR fixes it by using a\r\n`terms` aggregation if there are multiple values for a field so just\r\nthese get treated as `OR`.","sha":"3a48b7a84e587f0d5b9bffef0abecbce9c62e2e6"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#147597 Explain Log Rate Spikes: Fix mini histograms for groups with multiples values per field. (#147597)\n\nFor groups that have multiple values for the same field, the group\r\nhistogram query wasn't able to fetch data because it filters with a bool\r\n`must` and individual `term` aggregations. This PR fixes it by using a\r\n`terms` aggregation if there are multiple values for a field so just\r\nthese get treated as `OR`.","sha":"3a48b7a84e587f0d5b9bffef0abecbce9c62e2e6"}}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Dec 23, 2022
…tiples values per field. (elastic#147597) For groups that have multiple values for the same field, the group histogram query wasn't able to fetch data because it filters with a bool `must` and individual `term` aggregations. This PR fixes it by using a `terms` aggregation if there are multiple values for a field so just these get treated as `OR`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #146162.
For groups that have multiple values for the same field, the group histogram query wasn't able to fetch data because it filters with a bool
mustand individualtermaggregations. This PR fixes it by using atermsaggregation if there are multiple values for a field so just these get treated asOR.Before:
After:
Checklist