[ML] Explain Log Rate Spikes: Fix field candidate selection. #147614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2022
…#147614) The field candidate selection for Explain Log Rate Spikes was missing a check if the supported field type is also aggregatable. For example, a `keyword` type field could still be non-aggregatable if it was both not indexed and `doc_values` set to `false`. Additionally, if no groups were detected, we showed a "Try to continue analysis" button in the UI even if the analysis was able to finish. In this PR the artificial logs dataset for functional tests was extended to include a field like that. (cherry picked from commit aecad27)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2022
…147614) (#147792) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Explain Log Rate Spikes: Fix field candidate selection. (#147614)](#147614) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2022-12-19T17:35:31Z","message":"[ML] Explain Log Rate Spikes: Fix field candidate selection. (#147614)\n\nThe field candidate selection for Explain Log Rate Spikes was missing a\r\ncheck if the supported field type is also aggregatable. For example, a\r\n`keyword` type field could still be non-aggregatable if it was both not\r\nindexed and `doc_values` set to `false`. Additionally, if no groups were\r\ndetected, we showed a \"Try to continue analysis\" button in the UI even\r\nif the analysis was able to finish. In this PR the artificial logs dataset for functional tests was extended\r\nto include a field like that.","sha":"aecad27159764d8ea2d0aeddc94fd03954d480e5","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:ML/AIOps","v8.6.0","v8.7.0"],"number":147614,"url":"#147614 Explain Log Rate Spikes: Fix field candidate selection. (#147614)\n\nThe field candidate selection for Explain Log Rate Spikes was missing a\r\ncheck if the supported field type is also aggregatable. For example, a\r\n`keyword` type field could still be non-aggregatable if it was both not\r\nindexed and `doc_values` set to `false`. Additionally, if no groups were\r\ndetected, we showed a \"Try to continue analysis\" button in the UI even\r\nif the analysis was able to finish. In this PR the artificial logs dataset for functional tests was extended\r\nto include a field like that.","sha":"aecad27159764d8ea2d0aeddc94fd03954d480e5"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#147614 Explain Log Rate Spikes: Fix field candidate selection. (#147614)\n\nThe field candidate selection for Explain Log Rate Spikes was missing a\r\ncheck if the supported field type is also aggregatable. For example, a\r\n`keyword` type field could still be non-aggregatable if it was both not\r\nindexed and `doc_values` set to `false`. Additionally, if no groups were\r\ndetected, we showed a \"Try to continue analysis\" button in the UI even\r\nif the analysis was able to finish. In this PR the artificial logs dataset for functional tests was extended\r\nto include a field like that.","sha":"aecad27159764d8ea2d0aeddc94fd03954d480e5"}}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
crespocarlos
pushed a commit
to crespocarlos/kibana
that referenced
this pull request
Dec 23, 2022
…#147614) The field candidate selection for Explain Log Rate Spikes was missing a check if the supported field type is also aggregatable. For example, a `keyword` type field could still be non-aggregatable if it was both not indexed and `doc_values` set to `false`. Additionally, if no groups were detected, we showed a "Try to continue analysis" button in the UI even if the analysis was able to finish. In this PR the artificial logs dataset for functional tests was extended to include a field like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #146992.
The field candidate selection for Explain Log Rate Spikes was missing a check if the supported field type is also aggregatable. For example, a
keywordtype field could still be non-aggregatable if it was both not indexed anddoc_valuesset tofalse. Additionally, if no groups were detected, we showed a "Try to continue analysis" button in the UI even if the analysis was able to finish.In this PR the artificial logs dataset for functional tests was extended to include a field like that. Without the fixes of this PR the outcome in the UI with it looks like this:
With the fix applied to not show the button we get:
Finally, with the additional fix for field selection the whole warning callout disappears:
Checklist