Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add active filter count to agent status filter #147821

Merged
merged 1 commit into from Dec 20, 2022
Merged

[Fleet] Add active filter count to agent status filter #147821

merged 1 commit into from Dec 20, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Dec 19, 2022

Summary

The agent status filter previously did not have the badge with the number of available or active filter on it. Here it is now with the badge:

Screenshot 2022-12-19 at 22 51 52

Screenshot 2022-12-19 at 22 53 33

@hop-dev hop-dev added bug Fixes for quality problems that affect the customer experience release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 19, 2022
@hop-dev hop-dev self-assigned this Dec 19, 2022
@hop-dev hop-dev requested a review from a team as a code owner December 19, 2022 22:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@hop-dev hop-dev enabled auto-merge (squash) December 19, 2022 22:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 899.8KB 899.9KB +47.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 109 115 +6
securitySolution 439 445 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 70 76 +6
osquery 110 117 +7
securitySolution 516 522 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

juliaElastic
juliaElastic approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hop-dev hop-dev merged commit 792fe5e into elastic:main Dec 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 20, 2022
@hop-dev hop-dev deleted the bugfix-agent-status-filter-count branch December 20, 2022 09:41
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Dec 23, 2022
@hop-dev @crespocarlos
[Fleet] Add active filter count to agent status filter (elastic#147821)
f179fb7 
## Summary

The agent status filter previously did not have the badge with the
number of available or active filter on it. Here it is now with the
badge:

<img width="1254" alt="Screenshot 2022-12-19 at 22 51 52"
src="https://user-images.githubusercontent.com/3315046/208542579-4a8d8ea0-e2db-495f-9cb2-baf34aca822b.png">
<img width="1251" alt="Screenshot 2022-12-19 at 22 53 33"
src="https://user-images.githubusercontent.com/3315046/208542581-48b474fd-73bb-4647-b809-8703b05d1f6c.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@hop-dev hop-dev

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hop-dev @elasticmachine @kibana-ci @juliaElastic @kibanamachine