Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Flamegraph legend #147910

Merged
merged 13 commits into from Jan 16, 2023
Merged

[Profiling] Flamegraph legend #147910

merged 13 commits into from Jan 16, 2023

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Dec 21, 2022 •
edited

@dgieselaar dgieselaar requested a review from a team as a code owner December 21, 2022 10:15
@dgieselaar
Copy link
Member Author

@iogbole do you mind looking at the labels for the differential mode? I think more descriptive labels would be appropriate but I'm not sure what those would be. You might have showed something in our call but I can't remember exactly how it looked.

@iogbole
Copy link

iogbole commented Dec 29, 2022

@dgieselaar The legend for flamegrap h(https://github.com/elastic/prodfiler/issues/2810) LGMT.

However, the differential flamegraph legend needs to confirm to the mock in https://github.com/elastic/prodfiler/issues/2874

@kibanamachine kibanamachine requested a review from a team as a code owner January 10, 2023 09:04
@dgieselaar

This comment was marked as outdated.

Sign in to view
@dgieselaar dgieselaar removed the request for review from a team January 10, 2023 10:54
rockdaboot
rockdaboot approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgieselaar dgieselaar enabled auto-merge (squash) January 16, 2023 12:58
@dgieselaar dgieselaar merged commit 08d8555 into elastic:main Jan 16, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
profiling 112 115 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 237.8KB 240.3KB +2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
profiling 13.3KB 13.4KB +78.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 16, 2023
@KOTungseth KOTungseth added the Team:APM All issues that need APM UI Team support label Feb 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dgieselaar @iogbole @kibana-ci @elasticmachine @rockdaboot @KOTungseth @kibanamachine