[Discover] Support case-insensitive search in Document Viewer #148312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:fix
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
davismcphee
approved these changes
Jan 5, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 5, 2023
…c#148312) Closes elastic#147087 ## Summary This PR: - adds support for case-insensitive search - adds search highlights - fixes the tooltip when a field has a custom label <img width="744" alt="Screenshot 2023-01-03 at 17 09 20" src="https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png"> (cherry picked from commit 84693f6)
kibanamachine
added a commit
that referenced
this pull request
Jan 5, 2023
…148312) (#148429) # Backport This will backport the following commits from `main` to `8.6`: - [[Discover] Support case-insensitive search in Document Viewer (#148312)](#148312) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2023-01-05T07:58:47Z","message":"[Discover] Support case-insensitive search in Document Viewer (#148312)\n\nCloses #147087 Summary\r\n\r\nThis PR:\r\n- adds support for case-insensitive search \r\n- adds search highlights\r\n- fixes the tooltip when a field has a custom label\r\n\r\n<img width=\"744\" alt=\"Screenshot 2023-01-03 at 17 09 20\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":148312,"url":"https://github.com/elastic/kibana/pull/148312","mergeCommit":{"message":"[Discover] Support case-insensitive search in Document Viewer (#148312)\n\nCloses #147087 Summary\r\n\r\nThis PR:\r\n- adds support for case-insensitive search \r\n- adds search highlights\r\n- fixes the tooltip when a field has a custom label\r\n\r\n<img width=\"744\" alt=\"Screenshot 2023-01-03 at 17 09 20\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148312","number":148312,"mergeCommit":{"message":"[Discover] Support case-insensitive search in Document Viewer (#148312)\n\nCloses #147087 Summary\r\n\r\nThis PR:\r\n- adds support for case-insensitive search \r\n- adds search highlights\r\n- fixes the tooltip when a field has a custom label\r\n\r\n<img width=\"744\" alt=\"Screenshot 2023-01-03 at 17 09 20\"\r\nsrc=\"https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
![https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":148312,"url":"https://github.com/elastic/kibana/pull/148312","mergeCommit":{"message":"[Discover]](https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":148312,"url":"https://github.com/elastic/kibana/pull/148312","mergeCommit":{"message":"[Discover]){kind=link}
![https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148312","number":148312,"mergeCommit":{"message":"[Discover]](https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148312","number":148312,"mergeCommit":{"message":"[Discover]){kind=link}
![https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9](https://user-images.githubusercontent.com/1415710/210396131-529a3e76-a6cb-4026-b65a-018e1f627ac6.png\">","sha":"84693f6f312449327e86abfc5b1dc20871507da9){kind=link}
|
The backport was not included on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147087
Summary
This PR: