Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Create open API specification for delete/get connectors #148360

Merged
merged 8 commits into from Jan 10, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 4, 2023

Summary

Relates to #137240

This PR creates the open API specification for:

For now it simply sets additionalProperties: true for the config object, but that will be clarified when we add all the possible config combinations in a subsequent PR for the "create connector" API.

This PR also fixes the tags value for the existing connector API spec, since it was incorrectly set to cases.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX v8.7.0 8.6.1 labels Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Documentation preview:

@lcawl lcawl marked this pull request as ready for review January 4, 2023 15:45
@lcawl lcawl requested review from a team as code owners January 4, 2023 15:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl changed the title [DOCS] Create open API specification for get connector [DOCS] Create open API specification for get connectors Jan 4, 2023
@lcawl lcawl changed the title [DOCS] Create open API specification for get connectors [DOCS] Create open API specification for delete/get connectors Jan 5, 2023
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit a077a1d into elastic:main Jan 10, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 10, 2023
@lcawl lcawl added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jan 10, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 10, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 10, 2023
…148360) (#148667)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Create open API specification for delete/get connectors
(#148360)](#148360)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-01-10T18:58:58Z","message":"[DOCS]
Create open API specification for delete/get connectors
(#148360)","sha":"a077a1d468eea0a35434dda1288701fc02b34d92","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorsManagement","backport:prev-minor","v8.7.0","8.6.1"],"number":148360,"url":"#148360
Create open API specification for delete/get connectors
(#148360)","sha":"a077a1d468eea0a35434dda1288701fc02b34d92"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#148360
Create open API specification for delete/get connectors
(#148360)","sha":"a077a1d468eea0a35434dda1288701fc02b34d92"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
lcawl added a commit that referenced this pull request Jan 11, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 11, 2023
kibanamachine added a commit that referenced this pull request Jan 11, 2023
…d mute/unmute all alerts #148360 (#148494) (#148695)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Create open API specification for disable/enable rule and
mute/unmute all alerts #148360
(#148494)](#148494)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-01-11T00:01:16Z","message":"[DOCS]
Create open API specification for disable/enable rule and mute/unmute
all alerts #148360
(#148494)","sha":"b254abaf080fb8520036f9e3e44533c46f3423b1","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Alerting","Team:ResponseOps","docs","backport:prev-minor","v8.7.0","v8.6.1"],"number":148494,"url":"#148494
Create open API specification for disable/enable rule and mute/unmute
all alerts #148360
(#148494)","sha":"b254abaf080fb8520036f9e3e44533c46f3423b1"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#148494
Create open API specification for disable/enable rule and mute/unmute
all alerts #148360
(#148494)","sha":"b254abaf080fb8520036f9e3e44533c46f3423b1"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.1 v8.7.0
Development

Successfully merging this pull request may close these issues.

None yet

5 participants