Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] fix Maps not initialising time range from URL #148465

Merged
merged 10 commits into from Jan 9, 2023
Merged

[maps] fix Maps not initialising time range from URL #148465

merged 10 commits into from Jan 9, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 5, 2023

Fixes #148067

@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps v8.7.0 labels Jan 5, 2023
@nreese nreese marked this pull request as ready for review January 5, 2023 19:22
@nreese nreese requested a review from a team as a code owner January 5, 2023 19:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese requested a review from nickpeihl January 5, 2023 19:22
@nreese
Copy link
Contributor Author

nreese commented Jan 9, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 970 968 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +238.0B
Unknown metric groups

References to deprecated APIs

id before after diff
maps 27 25 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @nreese do you think this qualifies for a patch release in 8.6?

code review and tested in chrome

@nreese nreese added the v8.6.1 label Jan 9, 2023
@nreese
Copy link
Contributor Author

nreese commented Jan 9, 2023

do you think this qualifies for a patch release in 8.6?

Added 8.6.1 label

@nreese nreese added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jan 9, 2023
@nreese nreese merged commit 3b42548 into elastic:main Jan 9, 2023
@kibanamachine kibanamachine mentioned this pull request Jan 9, 2023
Merged
kibanamachine pushed a commit that referenced this pull request Jan 9, 2023
@nreese
[maps] fix Maps not initialising time range from URL (#148465)
e18fed3 
Fixes #148067

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3b42548)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Jan 9, 2023
@kibanamachine @nreese
[8.6] [maps] fix Maps not initialising time range from URL (#148465) (#…
6896a30 
…148597)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[maps] fix Maps not initialising time range from URL
(#148465)](#148465)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-01-09T21:17:15Z","message":"[maps]
fix Maps not initialising time range from URL (#148465)\n\nFixes
#148067:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3b42548aeb206c175d4d7a01e6dccddd71ec741e","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","auto-backport","Feature:Maps","v8.7.0","v8.6.1"],"number":148465,"url":"#148465
fix Maps not initialising time range from URL (#148465)\n\nFixes
#148067:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3b42548aeb206c175d4d7a01e6dccddd71ec741e"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#148465
fix Maps not initialising time range from URL (#148465)\n\nFixes
#148067:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3b42548aeb206c175d4d7a01e6dccddd71ec741e"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
@mistic mistic removed the v8.6.0 label Jan 10, 2023
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
@nreese @kibanamachine @jennypavlova
[maps] fix Maps not initialising time range from URL (elastic#148465)
9e83ae6 
Fixes elastic#148067

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Maps release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.1 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps+GX] Maps not initialising time range from URL
6 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @nickpeihl @mistic