Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Allows cleaning up of the filters agg custom label #148535

Merged
merged 1 commit into from Jan 9, 2023
Merged

[Lens] Allows cleaning up of the filters agg custom label #148535

merged 1 commit into from Jan 9, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 9, 2023 •
edited

Summary

Closes #148456

lens

By adding the allowFaslyValue setting this is fixed and now you can clean up the custom label on a Filters agg.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +21.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula changed the title [Lens] Fixes the cleaning up of the filters agg custom label [Lens] Allows cleaning up of the filters agg custom label Jan 9, 2023
@stratoula stratoula added release_note:fix Feature:Lens backport:skip This commit does not require backporting Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0 labels Jan 9, 2023
@stratoula stratoula marked this pull request as ready for review January 9, 2023 14:31
@stratoula stratoula requested a review from a team as a code owner January 9, 2023 14:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

dej611
dej611 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Safari 👍

It would be nice to have also a functional test for this

@stratoula stratoula merged commit 9382d19 into elastic:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Custom label on filters agg can't be cleaned up
4 participants
@stratoula @kibana-ci @elasticmachine @dej611