Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Update the sparklines to support the bar chart graph style #148702

Merged
merged 3 commits into from Jan 12, 2023
Merged

[APM] Update the sparklines to support the bar chart graph style #148702

merged 3 commits into from Jan 12, 2023

Conversation

MiriamAparicio
Copy link
Contributor

@MiriamAparicio MiriamAparicio commented Jan 11, 2023 •
edited

Closes #146982 and #125009

image

image

@MiriamAparicio MiriamAparicio added release_note:enhancement Team:APM All issues that need APM UI Team support backport:skip This commit does not require backporting v8.7.0 labels Jan 11, 2023
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner January 11, 2023 08:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kibanamachine kibanamachine requested a review from a team as a code owner January 11, 2023 08:35
ashokaditya
ashokaditya approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to security_solution/public/management/cypress/tsconfig.json are good.

@MiriamAparicio
Copy link
Contributor Author

Hi @ashokaditya, do you know why the CI auto commit changed this file?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +629.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ashokaditya
Copy link
Member

ashokaditya commented Jan 11, 2023 •
edited

Hi @ashokaditya, do you know why the CI auto commit changed this file?

Yes. Sorry, I should have mentioned in the review. It's due to /pull/148496 and that we have imported from these packages within cypress tests. The fact that the second PR went after the first one (and it did not do a master sync) created the missing dependencies.

@MiriamAparicio MiriamAparicio mentioned this pull request Jan 11, 2023
Merged
@boriskirov
Copy link
Contributor

@MiriamAparicio We should also expect the sparklines to support the comparison that we do, meaning in two colors so that way it is clear that it's taking two different periods in this case to compare.

@MiriamAparicio
Copy link
Contributor Author

MiriamAparicio commented Jan 11, 2023 •
edited

Hi @boriskirov, we're taking into account comparison, I think my screenshoot was not having previous data to compare, I will update it 🙏

ogupte
ogupte approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenlouv sorenlouv removed the request for review from pzl January 11, 2023 23:29
@MiriamAparicio MiriamAparicio merged commit b05880e into elastic:main Jan 12, 2023
@MiriamAparicio MiriamAparicio deleted the 146982-error-occurrences-charts branch January 12, 2023 08:30
@MiriamAparicio MiriamAparicio mentioned this pull request Jan 12, 2023
Closed
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
@MiriamAparicio @kibanamachine @jennypavlova
[APM] Update the sparklines to support the bar chart graph style (ela…
492bee6 
…stic#148702)

Closes elastic#146982 and
elastic#125009

<img width="1068" alt="image"
src="https://user-images.githubusercontent.com/31922082/211755721-2cff8d08-0b24-4f4d-b5dc-5199080094df.png">

<img width="1068" alt="image"
src="https://user-images.githubusercontent.com/31922082/211808834-f58e08ba-fd35-451c-9ec0-4b4676ae1494.png">

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@gbamparop gbamparop mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokaditya ashokaditya ashokaditya approved these changes

@ogupte ogupte ogupte approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Error sparkline and graph update
7 participants
@MiriamAparicio @elasticmachine @kibana-ci @ashokaditya @boriskirov @ogupte @kibanamachine