[ML] AIOps: Enhance the UX for grouped results which only contain field / value pairs that appear in other groups #148757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
5 tasks
| {repeatedValues.length > 0 && !valuesBadges.length ? ( | ||
| <FormattedMessage | ||
| id="xpack.aiops.explainLogRateSpikes.spikeAnalysisTableGroups.onlyMoreRepeatedLabel" | ||
| defaultMessage="{count, plural, one {# field/value pair} other {# more field/value pairs}} also appearing in other groups" |
There was a problem hiding this comment.
You need to drop the more from the other case too.
There was a problem hiding this comment.
Oh yes - don't know how I missed that 🙏 - added to the singular case in cf37b20
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #146162
This PR updates the UX for grouped results which only contain field / value pairs that appear in other groups. In the updated text the '+' and 'more' are dropped from the label.
Checklist
Delete any items that are not applicable to this PR.