Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region map settings clarifications #14893

Merged
merged 2 commits into from
Nov 15, 2017

Conversation

markwalkom
Copy link
Contributor

Expanded a whole bunch on the regionmap settings.

@thomasneirynck can I get you to review this and provide any feedback?

Expanded a whole bunch on the regionmap settings.
@markwalkom
Copy link
Contributor Author

I don't think fields.name is right, let me revisit that.

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

`url:`:: Mandatory. The location of the geojson file as provided by a webserver. This field also serves as a unique identifier for the file.
`attribution:`:: Optional. References the originating source of the geojson file.
`fields:`:: Mandatory. Each layer can contain multiple fields to indicate what properties from the geojson features you wish to expose. The example above shows how to define multiple properties.
`fields.name:`:: Mandatory. This value is used to do an inner-join between the document stored in Elasticsearch and the geojson file. eg if the field in the Elasticsearch is called `Location`, it must match a field in the geojson of the exact same name that Kibana can then use to lookup for the geoshape data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think eg is spelled e.g.

@markwalkom
Copy link
Contributor Author

Ok updated :)

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Nov 15, 2017

thx, I'll backport this

master, v6.2, v6.1: #15421
v6.0: #15422

thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Dec 5, 2017
Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Dec 5, 2017
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Dec 5, 2017
Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Dec 5, 2017
Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

fully qualify all names

fix asciidoc link

fix typo
thomasneirynck added a commit that referenced this pull request Dec 5, 2017
* Region map settings clarifications (#14893)

Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

It also fully qualify all names
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Dec 5, 2017
* Region map settings clarifications (elastic#14893)

Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

It also fully qualify all names
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Dec 5, 2017
* Region map settings clarifications (elastic#14893)

Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

It also fully qualify all names
thomasneirynck added a commit that referenced this pull request Dec 5, 2017
* Region map settings clarifications (#14893)

Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

It also fully qualify all parameter names.
thomasneirynck added a commit that referenced this pull request Dec 5, 2017
* Region map settings clarifications (#14893)

Improve documentation.

This also includes some additions to clarify the new includeElasticMapsService setting.

It also fully qualify all parameter names.
thomasneirynck added a commit that referenced this pull request Dec 6, 2017
* Region map settings clarifications (#14893)

Improve documentation

* use fully qualified paths
@spalger spalger deleted the markw/docs-regionmap-clarifications branch May 2, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants