-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region map settings clarifications #14893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded a whole bunch on the regionmap settings.
I don't think |
thomasneirynck
approved these changes
Nov 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
docs/setup/settings.asciidoc
Outdated
`url:`:: Mandatory. The location of the geojson file as provided by a webserver. This field also serves as a unique identifier for the file. | ||
`attribution:`:: Optional. References the originating source of the geojson file. | ||
`fields:`:: Mandatory. Each layer can contain multiple fields to indicate what properties from the geojson features you wish to expose. The example above shows how to define multiple properties. | ||
`fields.name:`:: Mandatory. This value is used to do an inner-join between the document stored in Elasticsearch and the geojson file. eg if the field in the Elasticsearch is called `Location`, it must match a field in the geojson of the exact same name that Kibana can then use to lookup for the geoshape data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think eg is spelled e.g.
Ok updated :) |
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 5, 2017
Improve documentation. This also includes some additions to clarify the new includeElasticMapsService setting.
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 5, 2017
Improve documentation
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 5, 2017
Improve documentation. This also includes some additions to clarify the new includeElasticMapsService setting.
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 5, 2017
Improve documentation. This also includes some additions to clarify the new includeElasticMapsService setting. fully qualify all names fix asciidoc link fix typo
thomasneirynck
added a commit
that referenced
this pull request
Dec 5, 2017
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 5, 2017
* Region map settings clarifications (elastic#14893) Improve documentation. This also includes some additions to clarify the new includeElasticMapsService setting. It also fully qualify all names
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Dec 5, 2017
* Region map settings clarifications (elastic#14893) Improve documentation. This also includes some additions to clarify the new includeElasticMapsService setting. It also fully qualify all names
thomasneirynck
added a commit
that referenced
this pull request
Dec 5, 2017
thomasneirynck
added a commit
that referenced
this pull request
Dec 5, 2017
thomasneirynck
added a commit
that referenced
this pull request
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded a whole bunch on the regionmap settings.
@thomasneirynck can I get you to review this and provide any feedback?