[Security Solution] Display job friendly name on detection pages #148974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
siem-explore-148973
branch
from
8519b41
to
a1aced6
Compare
machadoum
added
release_note:enhancement
Team:Threat Hunting
machadoum
force-pushed
the
siem-explore-148973
branch
from
a1aced6
to
86e99c9
Compare
|
@elasticmachine merge upstream |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
xcrzx
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Pulled in and tested locally, and everything works as expected. Thank you, @machadoum 👍
|
This will also resolve #147722 that I opened a little while back @machadoum 🙂 |
|
@elasticmachine merge upstream |
machadoum
force-pushed
the
siem-explore-148973
branch
from
79d1c3f
to
92e9057
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
After updating the UI to display the job name, we lost the search by job id feature. Because some users might be used to search by id, this commit reintroduces the feature.
machadoum
force-pushed
the
siem-explore-148973
branch
from
81d2b30
to
af3c52d
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
…stic#148974) issue: elastic#148973 Similar to: elastic#146772 ## Summary When friendly names are available as job meta information, we should display it on: * Manage Rules table - Job warning message * New rule page - Machine Learning job selector * Rule details page - Machine Learning job description and warning message <img width="600" alt="Screenshot 2023-01-16 at 14 34 50" src="https://user-images.githubusercontent.com/1490444/212692378-9fcb59b5-179c-4054-b2b8-9972b9f35bab.png"> <img width="600" alt="Screenshot 2023-01-16 at 14 33 14" src="https://user-images.githubusercontent.com/1490444/212692408-bc978eea-a4c6-4a43-bb67-3098969da7e2.png"> <img width="600" alt="Screenshot 2023-01-16 at 13 39 51" src="https://user-images.githubusercontent.com/1490444/212692445-8bacb22d-5160-45f7-aa56-ec5f296d3fb4.png"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #148973
Similar to: #146772
Summary
When friendly names are available as job meta information, we should display it on:
Checklist