[ML] Delayed data visualization: ensure y-axis count is visible #148982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
:ml
Feature:Anomaly Detection
2 tasks
peteharverson
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
LGTM.
With this change, you can see that when the datafeed is running but there are no source docs, we aren't setting the y axis minimum to 0. Can we fix the y axis minimum to 0? Maybe worth adding to #143702 if it isn't something you want to add to this PR.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
adcoelho
pushed a commit
to adcoelho/kibana
that referenced
this pull request
Jan 23, 2023
…tic#148982) ## Summary Related issue: elastic#143702 Ensure the y-axis counts are visible in the delayed data chart. Default `Show model snapshots` to be initially unchecked/hidden. <img width="615" alt="image" src="https://user-images.githubusercontent.com/6446462/212722354-59b292d9-06ec-469d-95ea-617a130bc299.png"> ## NOTE Looks like this shouldn't explicitly need to be turned into a String() - a limitation on EUI Charts side - they will be updating on their end so that it's not necessary but for now this work-around is needed so that the y-axis values show up. ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alvarezmelissa87
added
release_note:fix
and removed
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #143702
Ensure the y-axis counts are visible in the delayed data chart.
Default
Show model snapshotsto be initially unchecked/hidden.NOTE
Looks like this shouldn't explicitly need to be turned into a String() - a limitation on EUI Charts side - they will be updating on their end so that it's not necessary but for now this work-around is needed so that the y-axis values show up.
Checklist
Delete any items that are not applicable to this PR.