Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixing bucket span estimator in advanced wizard #149008

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jan 17, 2023

In the advanced wizard the bucket span estimator is always disabled.
This was caused by an incorrect update check.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.7.0 v8.6.1 labels Jan 17, 2023
@jgowdyelastic jgowdyelastic self-assigned this Jan 17, 2023
@jgowdyelastic jgowdyelastic marked this pull request as ready for review January 17, 2023 10:05
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner January 17, 2023 10:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 1af7e36 into elastic:main Jan 19, 2023
@jgowdyelastic jgowdyelastic deleted the fix-bucket-span-estimator-in-adv-wizard branch January 19, 2023 11:18
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 19, 2023
In the advanced wizard the bucket span estimator is always disabled.
This was caused by an incorrect update check.

(cherry picked from commit 1af7e36)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 19, 2023
…149201)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[ML] Fixing bucket span estimator in advanced wizard
(#149008)](#149008)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2023-01-19T11:17:53Z","message":"[ML]
Fixing bucket span estimator in advanced wizard (#149008)\n\nIn the
advanced wizard the bucket span estimator is always disabled.\r\nThis
was caused by an incorrect update
check.","sha":"1af7e3626b78ff53d7b3f45cc44b20006e5a8426","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:Anomaly
Detection","v8.7.0","v8.6.1"],"number":149008,"url":"#149008
Fixing bucket span estimator in advanced wizard (#149008)\n\nIn the
advanced wizard the bucket span estimator is always disabled.\r\nThis
was caused by an incorrect update
check.","sha":"1af7e3626b78ff53d7b3f45cc44b20006e5a8426"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#149008
Fixing bucket span estimator in advanced wizard (#149008)\n\nIn the
advanced wizard the bucket span estimator is always disabled.\r\nThis
was caused by an incorrect update
check.","sha":"1af7e3626b78ff53d7b3f45cc44b20006e5a8426"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
wayneseymour pushed a commit to wayneseymour/kibana that referenced this pull request Jan 19, 2023
In the advanced wizard the bucket span estimator is always disabled.
This was caused by an incorrect update check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.6.1 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants