New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix responsive behaviour of page header with date picker #149073
[ML] Fix responsive behaviour of page header with date picker #149073
Conversation
547fd85
to
5ac32ef
Compare
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested (Chrome and Firefox) and LGTM
@@ -18,6 +19,10 @@ import { HelpMenu } from '../components/help_menu'; | |||
import { useMlKibana } from '../contexts/kibana'; | |||
import { MlPageHeader } from '../components/page_header'; | |||
|
|||
const singleMetricViewerTitle = css({ | |||
minWidth: '350px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other pages are 300px
is this larger size to account for wider text?
If so, this text will be translated and could be any size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch regarding translations! In 9a68a79 I combined the different rules and they now are all minWidth: 300px
.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsmiscellaneous assets size
References to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @walterra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Fixes #148381.
Improve responsive behaviour of page header with date picker.
width
option.flexGroup
boolean toggle to be able to get back the flex items only without the flex group if you want to embed the date picker in an already existing flex group to avoid additional nesting.fill
option of the refresh button tofalse
to avoid the dark blue "primary".aiops
plugin and theml_page.tsx
component, migrates away from EUI's deprecated components for the page layout.min-width
to page titles to avoid narrow wrapping (e.g. wrapping after each character on narrow screens).Before (cut off date picker and refresh button):
After:
Before (narrow wrapping of page title):
After:
Checklist