[Synthetics] omit ssl fields when ssl is disabled #149087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dominiqueclarke
added
v8.7.0
8.6.1
release_note:fix
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
dominiqueclarke
changed the title
awahab07
approved these changes
Jan 18, 2023
dominiqueclarke
added
v8.6.1
auto-backport
kibanamachine
pushed a commit
that referenced
this pull request
Jan 19, 2023
## Summary Resolves #149083 Omits SSL fields when TLS is disabled. ### Testing Testing should be done both in the Uptime and Synthetics app 1. Create a TCP monitor in the Uptime and synthetics app with the following host `8.8.8.8:80` 2. Navigate to the monitor details page for each monitor, either in the Synthetics or Uptime app. 3. Confirm that the url for the monitor is `tcp://8.8.8.8:80`, not `ssl:/8.8.8.8:80`. (cherry picked from commit 55bb5c3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
wayneseymour
pushed a commit
to wayneseymour/kibana
that referenced
this pull request
Jan 19, 2023
## Summary Resolves elastic#149083 Omits SSL fields when TLS is disabled. ### Testing Testing should be done both in the Uptime and Synthetics app 1. Create a TCP monitor in the Uptime and synthetics app with the following host `8.8.8.8:80` 2. Navigate to the monitor details page for each monitor, either in the Synthetics or Uptime app. 3. Confirm that the url for the monitor is `tcp://8.8.8.8:80`, not `ssl:/8.8.8.8:80`.
kibanamachine
added a commit
that referenced
this pull request
Jan 19, 2023
…49228) # Backport This will backport the following commits from `main` to `8.6`: - [[Synthetics] omit ssl fields when ssl is disabled (#149087)](#149087) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-01-19T14:13:55Z","message":"[Synthetics] omit ssl fields when ssl is disabled (#149087)\n\n## Summary\r\nResolves #149083 SSL fields when TLS is disabled.\r\n\r\n### Testing\r\nTesting should be done both in the Uptime and Synthetics app\r\n1. Create a TCP monitor in the Uptime and synthetics app with the\r\nfollowing host `8.8.8.8:80`\r\n2. Navigate to the monitor details page for each monitor, either in the\r\nSynthetics or Uptime app.\r\n3. Confirm that the url for the monitor is `tcp://8.8.8.8:80`, not\r\n`ssl:/8.8.8.8:80`.","sha":"55bb5c307015662fd309c5cc86ebbf59fb6f8e77","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:uptime","auto-backport","v8.7.0","v8.6.1"],"number":149087,"url":"#149087 omit ssl fields when ssl is disabled (#149087)\n\n## Summary\r\nResolves #149083 SSL fields when TLS is disabled.\r\n\r\n### Testing\r\nTesting should be done both in the Uptime and Synthetics app\r\n1. Create a TCP monitor in the Uptime and synthetics app with the\r\nfollowing host `8.8.8.8:80`\r\n2. Navigate to the monitor details page for each monitor, either in the\r\nSynthetics or Uptime app.\r\n3. Confirm that the url for the monitor is `tcp://8.8.8.8:80`, not\r\n`ssl:/8.8.8.8:80`.","sha":"55bb5c307015662fd309c5cc86ebbf59fb6f8e77"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"#149087 omit ssl fields when ssl is disabled (#149087)\n\n## Summary\r\nResolves #149083 SSL fields when TLS is disabled.\r\n\r\n### Testing\r\nTesting should be done both in the Uptime and Synthetics app\r\n1. Create a TCP monitor in the Uptime and synthetics app with the\r\nfollowing host `8.8.8.8:80`\r\n2. Navigate to the monitor details page for each monitor, either in the\r\nSynthetics or Uptime app.\r\n3. Confirm that the url for the monitor is `tcp://8.8.8.8:80`, not\r\n`ssl:/8.8.8.8:80`.","sha":"55bb5c307015662fd309c5cc86ebbf59fb6f8e77"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
|
Failing on Uptime
|
|
Raised #150949 |
|
#152239 and #150949 have been merged into 8.7. @emilioalvap You can retest if you'd like |
|
Post-FF Testing LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #149083
Omits SSL fields when TLS is disabled.
Testing
Testing should be done both in the Uptime and Synthetics app
8.8.8.8:80tcp://8.8.8.8:80, notssl:/8.8.8.8:80.