[Fleet] Agent List: Inform users when agents have become inactive since last page view #149226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
commented
Jan 19, 2023
| @@ -0,0 +1,202 @@ | |||
| /* | |||
There was a problem hiding this comment.
I have moved the agent status filter to its own component as it has got a bit more complex
|
@elasticmachine merge upstream |
hop-dev
added
release_note:enhancement
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
approved these changes
Jan 19, 2023
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
kibanamachine
added
v8.7.0
backport:skip
adcoelho
pushed a commit
to adcoelho/kibana
that referenced
this pull request
Jan 23, 2023
…ce last page view (elastic#149226)
5 tasks
criamico
added a commit
that referenced
this pull request
Feb 19, 2024
Fixes #176124 ## Summary The [inactive popover](#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 851657c)
criamico
added a commit
to criamico/kibana
that referenced
this pull request
Feb 19, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 851657c) # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_status_filter.tsx
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Feb 19, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
criamico
added a commit
that referenced
this pull request
Feb 20, 2024
…7172) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix inactive popover tour not resetting (#176929)](#176929) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-19T10:25:20Z","message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes #176124 Summary\r\nThe [inactive popover](#149226 appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.13.0","v8.12.2","v8.14.0"],"number":176929,"url":"#176929 Fix inactive popover tour not resetting (#176929)\n\nFixes #176124 Summary\r\nThe [inactive popover](#149226 appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"#177161 Fix inactive popover tour not resetting (#176929)\n\nFixes #176124 Summary\r\nThe [inactive popover](#149226 appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}}]}] BACKPORT-->
kibanamachine
added a commit
that referenced
this pull request
Feb 21, 2024
…7161) # Backport This will backport the following commits from `main` to `8.13`: - [[Fleet] Fix inactive popover tour not resetting (#176929)](#176929) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"criamico@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-02-19T10:25:20Z","message":"[Fleet] Fix inactive popover tour not resetting (#176929)\n\nFixes #176124 Summary\r\nThe [inactive popover](#149226 appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v8.13.0","v8.12.2","v8.14.0"],"title":"[Fleet] Fix inactive popover tour not resetting","number":176929,"url":"#176929 Fix inactive popover tour not resetting (#176929)\n\nFixes #176124 Summary\r\nThe [inactive popover](#149226 appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"#176929 Fix inactive popover tour not resetting (#176929)\n\nFixes #176124 Summary\r\nThe [inactive popover](#149226 appears the first time after agents become inactive was broken\r\n(probably because of a EUi upgrade) and wasn't dismissable anymore.\r\n\r\nI'm adding a footer with button that makes it easily dismissable.\r\n\r\n\r\n\r\n### Testing \r\n- In dev tools console, run the following. This removes from the local\r\nstorage the key that signals that the tour was already ran once.\r\n```\r\n localStorage.removeItem(\"fleet.inactiveAgentsCalloutHasBeenDismissed\")\r\n```\r\n- Enroll some agents and wait that at least one becomes inactive\r\n- The popover should be visible and it should be possible to dismiss it\r\nby clicking \"got it\".\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"851657c6f9fd0113f3a5900c100ce0f3e151841f"}}]}] BACKPORT--> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Fixes elastic#176124 ## Summary The [inactive popover](elastic#149226) that appears the first time after agents become inactive was broken (probably because of a EUi upgrade) and wasn't dismissable anymore. I'm adding a footer with button that makes it easily dismissable.  ### Testing - In dev tools console, run the following. This removes from the local storage the key that signals that the tour was already ran once. ``` localStorage.removeItem("fleet.inactiveAgentsCalloutHasBeenDismissed") ``` - Enroll some agents and wait that at least one becomes inactive - The popover should be visible and it should be possible to dismiss it by clicking "got it". Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #148285
When agents have become inactive since the user last viewed the agents, display a tour popover showing them how/where to apply filters to view them.
The tour popover is only displayed once, once the user clicks the agent status filters it is hidden, and we store in local storage to keep it hidden in the future.
Local storage is used to track the last number of inactive agents the user saw.
###Testing
Note: to reset the popover state to not having been viewied, in dev tools console run:
for dev testing the createAgents script is very handy:
Test steos: