renderCustomActionsRow with named params instead of args #149304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcger
added
release_note:enhancement
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
jcger
commented
Jan 23, 2023
| @@ -518,13 +518,15 @@ export interface BulkActionsConfig { | |||
| ) => void; | |||
| } | |||
|
|
|||
| export interface RenderCustomActionsRowArgs { | |||
There was a problem hiding this comment.
let me know if you come up with a better name please
There was a problem hiding this comment.
Nothing comes to my mind 🙈
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
guskovaue
approved these changes
Jan 23, 2023
maryam-saeidi
approved these changes
Jan 23, 2023
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 24, 2023
* main: (54 commits) [APM] Allow calling `createInternalESClient` without `context` (elastic#149320) [Synthetics] Errors list active state (elastic#149387) [FTRs] Execution Context: fix no data flakiness (elastic#149406) [Cloud Posture] - Deprecate csp rule remove migration object (elastic#148530) Bump elasticsearch-js to 8.6.0-canary.3 (elastic#148521) [Fleet] Use optimistic locking when updating `installed_es` on input package policy creation (elastic#148883) [ML] Remove job_type from job definitions in modules (elastic#149247) [ML] Consolidate `query_utils` into package `@kbn/ml-query-utils` (elastic#149224) [Synthetics] Better formatting for waterfall timeline tooltips (elastic#149142) [Cloud Posture] CIS AWS support - changes to findings tables (elastic#148945) [Lens] Enable previous time shift when using a date histogram (elastic#149126) [Synthetics] Object types panel and thresholds (elastic#149099) [Fleet] added back batch exec for update tags (elastic#148618) 148790 - Fix scroll style for setup guide flyout (elastic#149242) Fix a11y issue with dev tool tabs (elastic#149349) [APM] Fix mobile indices (elastic#149230) [Dashboard] Fix Phrase_filter query for scripted fields (elastic#148942) (elastic#148943) renderCustomActionsRow with named params instead of args (elastic#149304) [ML] Adding ML execution context to es requests (elastic#148746) [Custom Branding] Replace EuiLoadingElastic with EuiLoadingSpinner (elastic#149261) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #149303
QA
Run the alerts table and check that the actions cell is working.
Screen.Recording.2023-01-23.at.10.45.14.mov