Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Filter and sort case activities #149396

Merged

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Jan 24, 2023

Summary

This PR adds filter and sort options for filtering user activities on Cases view.
You can filter by All, Comments and History options. You can sort by ascending or descending options.

Issue: #140096, #149191

trimmed_filter_many_comments.mov

Took below decisions to not overcomplicate this PR

  • Use the EuiCommentList at the moment for Description component and remove it/improve it in future PR
  • Put the Description component inside the left section of Activity tab to show description and Sidebar section together

Checklist

Flakey test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1928

For maintainers

Release notes

Adds filtering and sorting for the case activity.

@js-jankisalvi js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels Jan 24, 2023
@js-jankisalvi js-jankisalvi self-assigned this Jan 24, 2023
@js-jankisalvi js-jankisalvi changed the title created filter, sort activity components [Cases] filter case activities Jan 24, 2023
js-jankisalvi and others added 21 commits February 9, 2023 16:41
<EuiFlexItem data-test-subj="case-view-alerts">
<CaseViewTabs caseData={caseData} activeTab={CASE_VIEW_PAGE_TABS.ALERTS} />
<EuiFlexGroup>
<EuiFlexItem style={{ minHeight: 300 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the css prop instead of style

Copy link
Member

@cnasikas cnasikas Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minHeight adds a gray area below the table. Do we need it?

Screenshot 2023-02-22 at 5 01 38 PM

Copy link
Contributor Author

@js-jankisalvi js-jankisalvi Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without providing height, it doesn't show last entry properly, adds scroll even though it has enough space to show data when multiple alerts are added:

image

Copy link
Contributor Author

@js-jankisalvi js-jankisalvi Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added min-height as it similar to what is suggested by Eui :

When placed within an EuiFlexGroup and EuiFlexItem, the data grid will have trouble shrinking to fit. To fix this, you will need to manually add a style of min-width: 0 to the EuiFlexItem.

However min-height: 0 did not show grid with all rows , So I set it to 300.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 551 557 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 367.1KB 371.4KB +4.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 130.4KB 130.9KB +480.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 56 57 +1

Total ESLint disabled count

id before after diff
cases 74 75 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @js-jankisalvi!! Code LGTM. I tested and everything is working as expected 🚀 .

@js-jankisalvi js-jankisalvi merged commit fd15498 into elastic:main Feb 23, 2023
@js-jankisalvi js-jankisalvi deleted the filter-case-view-activity-bar branch October 6, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:feature Makes this part of the condensed release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants