-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Filter and sort case activities #149396
[Cases] Filter and sort case activities #149396
Conversation
…-ref HEAD~1..HEAD --fix'
…-jankisalvi/kibana into filter-case-view-activity-bar
…-jankisalvi/kibana into filter-case-view-activity-bar
…-jankisalvi/kibana into filter-case-view-activity-bar
…-jankisalvi/kibana into filter-case-view-activity-bar
…-jankisalvi/kibana into filter-case-view-activity-bar
…-ref HEAD~1..HEAD --fix'
…-jankisalvi/kibana into filter-case-view-activity-bar
x-pack/plugins/cases/public/components/case_view/case_view_page.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/case_view_tabs.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/case_view_page.test.tsx
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/components/case_view_activity.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/components/case_view_activity.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/components/case_view/components/case_view_activity.tsx
Outdated
Show resolved
Hide resolved
<EuiFlexItem data-test-subj="case-view-alerts"> | ||
<CaseViewTabs caseData={caseData} activeTab={CASE_VIEW_PAGE_TABS.ALERTS} /> | ||
<EuiFlexGroup> | ||
<EuiFlexItem style={{ minHeight: 300 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use the css
prop instead of style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added min-height as it similar to what is suggested by Eui :
When placed within an EuiFlexGroup and EuiFlexItem, the data grid will have trouble shrinking to fit. To fix this, you will need to manually add a style of min-width: 0 to the EuiFlexItem.
However min-height: 0
did not show grid with all rows , So I set it to 300.
x-pack/plugins/cases/public/containers/use_get_case_user_actions_stats.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cases/public/containers/use_get_case_user_actions_stats.test.tsx
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @js-jankisalvi!! Code LGTM. I tested and everything is working as expected 🚀 .
Summary
This PR adds filter and sort options for filtering user activities on Cases view.
You can filter by
All
,Comments
andHistory
options. You can sort byascending
ordescending
options.Issue: #140096, #149191
trimmed_filter_many_comments.mov
Took below decisions to not overcomplicate this PR
EuiCommentList
at the moment forDescription
component and remove it/improve it in future PRDescription
component inside the left section of Activity tab to show description and Sidebar section togetherChecklist
Flakey test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1928
For maintainers
Release notes
Adds filtering and sorting for the case activity.