[ML] Review UI text of population, advanced, categ, rare, and geo wizards #149407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabosteve
added
:ml
release_note:skip
…-ref HEAD~1..HEAD --fix'
|
Pinging @elastic/ml-ui (:ml) |
|
@jgowdyelastic Could you please help me to remove the title "Enable per-partition categorization" above the corresponding switch in the Advanced wizard when the time permits? I tried the usual methods but they didn't work. |
...n/jobs/new_job/pages/components/pick_fields_step/components/population_field/description.tsx
Outdated
Show resolved
Hide resolved
|
This text has probably been through the review process already, but just wondered if
|
|
Not touched by the current PR, but here are some additional comments about text seen in these screenshots:
|
lcawl
reviewed
Jan 26, 2023
.../pick_fields_step/components/categorization_partition_field/categorization_per_partition.tsx
Show resolved
Hide resolved
lcawl
reviewed
Jan 26, 2023
.../pages/components/pick_fields_step/components/categorization_partition_field/description.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
…ards (elastic#149407) ## Summary This PR adjusts the anomaly detection UI text to be shorter, cleaner, and more in line with the EUI guidelines. The field names above the field selectors are removed.
darnautov
pushed a commit
to darnautov/kibana
that referenced
this pull request
Feb 7, 2023
…ards (elastic#149407) ## Summary This PR adjusts the anomaly detection UI text to be shorter, cleaner, and more in line with the EUI guidelines. The field names above the field selectors are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: https://github.com/elastic/ml-team/issues/845
This PR adjusts the anomaly detection UI text to be shorter, cleaner, and more in line with the EUI guidelines. The field names above the field selectors are removed.
Population
Before
After
Advanced
Before
After
Categorization
Before
After
Rare
Before
After
Geo
After