Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] reset_jobs api tests #150880

Merged
merged 2 commits into from
Feb 10, 2023
Merged

[ML] reset_jobs api tests #150880

merged 2 commits into from
Feb 10, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 10, 2023 •
edited by kibanamachine

Adds tests for the reset_jobs endpoint.
What's tested:

  • jobs are reset and the processed records counts are correct reduced to 0
  • User annotations are correctly deleted after reset, if the endpoint is told to do so.

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0 labels Feb 10, 2023
@jgowdyelastic jgowdyelastic self-assigned this Feb 10, 2023
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 10, 2023 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Feb 10, 2023
Closed
14 tasks
pheyos
pheyos reviewed Feb 10, 2023
View reviewed changes
x-pack/test/functional/services/ml/api.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/api.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/jobs/reset.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/jobs/reset.ts Outdated Show resolved Hide resolved
pheyos
pheyos approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 67f01ed into elastic:main Feb 10, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 10, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 10, 2023
@jgowdyelastic
[ML] reset_jobs api tests (elastic#150880)
673637d 
Adds tests for the `reset_jobs` endpoint.
What's tested:
- jobs are reset and the processed records counts are correct reduced to
0
- User annotations are correctly deleted after reset, if the endpoint is
told to do so.

(cherry picked from commit 67f01ed)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 10, 2023
@kibanamachine @jgowdyelastic
[8.7] [ML] reset_jobs api tests (#150880) (#150922)
b34f98c 
# Backport

This will backport the following commits from `main` to `8.7`:
- [[ML] reset_jobs api tests
(#150880)](#150880)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2023-02-10T16:37:15Z","message":"[ML]
reset_jobs api tests (#150880)\n\nAdds tests for the `reset_jobs`
endpoint.\r\nWhat's tested:\r\n- jobs are reset and the processed
records counts are correct reduced to\r\n0\r\n- User annotations are
correctly deleted after reset, if the endpoint is\r\ntold to do
so.","sha":"67f01ed27d3e851f28e291ca151425a9a3f9dcc3","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v8.7.0","v8.8.0"],"number":150880,"url":"#150880
reset_jobs api tests (#150880)\n\nAdds tests for the `reset_jobs`
endpoint.\r\nWhat's tested:\r\n- jobs are reset and the processed
records counts are correct reduced to\r\n0\r\n- User annotations are
correctly deleted after reset, if the endpoint is\r\ntold to do
so.","sha":"67f01ed27d3e851f28e291ca151425a9a3f9dcc3"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150880
reset_jobs api tests (#150880)\n\nAdds tests for the `reset_jobs`
endpoint.\r\nWhat's tested:\r\n- jobs are reset and the processed
records counts are correct reduced to\r\n0\r\n- User annotations are
correctly deleted after reset, if the endpoint is\r\ntold to do
so.","sha":"67f01ed27d3e851f28e291ca151425a9a3f9dcc3"}}]}] BACKPORT-->

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @pheyos