-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] update_trained_models_spaces api tests #150901
Merged
jgowdyelastic
merged 3 commits into
elastic:main
from
jgowdyelastic:update_trained_models_spaces-api-tests
Feb 10, 2023
Merged
[ML] update_trained_models_spaces api tests #150901
jgowdyelastic
merged 3 commits into
elastic:main
from
jgowdyelastic:update_trained_models_spaces-api-tests
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-ui (:ml) |
pheyos
reviewed
Feb 10, 2023
x-pack/test/api_integration/apis/ml/saved_objects/update_trained_model_spaces.ts
Outdated
Show resolved
Hide resolved
pheyos
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2023
Adds tests for the `update_trained_models_spaces` endpoint (cherry picked from commit 648786e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[ML] update_trained_models_spaces api tests (#150901)](#150901) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2023-02-10T16:53:10Z","message":"[ML] update_trained_models_spaces api tests (#150901)\n\nAdds tests for the `update_trained_models_spaces` endpoint","sha":"648786e5329ebe6a397fa423f47a4d0b6fbe08cd","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v8.7.0","v8.8.0"],"number":150901,"url":"#150901 update_trained_models_spaces api tests (#150901)\n\nAdds tests for the `update_trained_models_spaces` endpoint","sha":"648786e5329ebe6a397fa423f47a4d0b6fbe08cd"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#150901 update_trained_models_spaces api tests (#150901)\n\nAdds tests for the `update_trained_models_spaces` endpoint","sha":"648786e5329ebe6a397fa423f47a4d0b6fbe08cd"}}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:ml
non-issue
Indicates to automation that a pull request should not appear in the release notes
release_note:skip
Skip the PR/issue when compiling release notes
v8.7.0
v8.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the
update_trained_models_spaces
endpoint