Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Get rid of rule description's fade in/out effect #150998

Merged
merged 6 commits into from Feb 21, 2023
Merged

[Security Solution] Get rid of rule description's fade in/out effect #150998

merged 6 commits into from Feb 21, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Feb 13, 2023 •
edited by kibanamachine

Addresses: #150997

Summary

It removed rule details description's fade in and out effect which was added by scrolling EUI styles.

Before:

Screenshot 2023-02-13 at 13 30 02

Screenshot 2023-02-13 at 13 30 11

After:

Screenshot 2023-02-13 at 13 27 49

Screenshot 2023-02-13 at 13 28 00

@maximpn maximpn added release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Rule Details Security Solution Detection Rule Details backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.7.0 labels Feb 13, 2023
@maximpn maximpn self-assigned this Feb 13, 2023
@maximpn maximpn marked this pull request as ready for review February 13, 2023 12:40
@maximpn maximpn requested a review from a team as a code owner February 13, 2023 12:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maximpn
Copy link
Contributor Author

maximpn commented Feb 13, 2023

@elasticmachine merge upstream

2 similar comments
@maximpn
Copy link
Contributor Author

maximpn commented Feb 14, 2023

@elasticmachine merge upstream

@banderror
Copy link
Contributor

@elasticmachine merge upstream

banderror
banderror approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @maximpn! I tested it locally and left a nit comment for your consideration 👍

...ugins/security_solution/public/detections/components/rules/step_about_rule_details/index.tsx Outdated
@@ -129,7 +129,7 @@ const StepAboutRuleToggleDetailsComponent: React.FC<StepPanelProps> = ({
{(resizeRef) => (
<AboutContent ref={resizeRef}>
<VerticalOverflowContainer maxHeight={120}>
<VerticalOverflowContent maxHeight={120} className="eui-yScrollWithShadows">
<VerticalOverflowContent maxHeight={120} className="eui-yScroll">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: VerticalOverflowContent is a styled-component, and we could specify the eui-yScroll class name in it for reusability and remove it from the 3 places where this component is rendered.

@maximpn maximpn force-pushed the fix-rule-details-description-fade-in-out branch from 20d269d to d22f0fb Compare February 20, 2023 14:56
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3681 3682 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 13.7MB +404.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@maximpn maximpn merged commit de97462 into elastic:main Feb 21, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 21, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 21, 2023
@maximpn
[Security Solution] Get rid of rule description's fade in/out effect (e…
c3538c2 
…lastic#150998)

**Addresses:** elastic#150997

## Summary

It removed rule details description's fade in and out effect which was added by scrolling EUI styles.

*Before:*

![Screenshot 2023-02-13 at 13 30 02](https://user-images.githubusercontent.com/3775283/218459498-28dd50ce-94eb-427f-865c-279f611b4049.png)

![Screenshot 2023-02-13 at 13 30 11](https://user-images.githubusercontent.com/3775283/218459532-56072024-8e8b-4ee1-89be-ffece60d31a7.png)

*After:*

![Screenshot 2023-02-13 at 13 27 49](https://user-images.githubusercontent.com/3775283/218459699-8da6f5c3-e05d-4c9f-8122-392f3bfd6846.png)

![Screenshot 2023-02-13 at 13 28 00](https://user-images.githubusercontent.com/3775283/218459735-1c522e19-573f-47c4-9490-5828373ac5ac.png)

(cherry picked from commit de97462)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@banderror banderror added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Feb 21, 2023
kibanamachine added a commit that referenced this pull request Feb 21, 2023
@kibanamachine @maximpn
[8.7] [Security Solution] Get rid of rule description's fade in/out e…
afa799b 
…ffect (#150998) (#151683)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Get rid of rule description's fade in/out effect
(#150998)](#150998)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-02-21T10:48:03Z","message":"[Security
Solution] Get rid of rule description's fade in/out effect
(#150998)\n\n**Addresses:**
#150997
Summary\r\n\r\nIt removed rule details description's fade in and out
effect which was added by scrolling EUI
styles.\r\n\r\n*Before:*\r\n\r\n![Screenshot 2023-02-13 at 13 30
02](https://user-images.githubusercontent.com/3775283/218459498-28dd50ce-94eb-427f-865c-279f611b4049.png)\r\n\r\n![Screenshot
2023-02-13 at 13 30
11](https://user-images.githubusercontent.com/3775283/218459532-56072024-8e8b-4ee1-89be-ffece60d31a7.png)\r\n\r\n*After:*\r\n\r\n![Screenshot
2023-02-13 at 13 27
49](https://user-images.githubusercontent.com/3775283/218459699-8da6f5c3-e05d-4c9f-8122-392f3bfd6846.png)\r\n\r\n![Screenshot
2023-02-13 at 13 28
00](https://user-images.githubusercontent.com/3775283/218459735-1c522e19-573f-47c4-9490-5828373ac5ac.png)","sha":"de97462358fb859590693b1cca43c20b23f30c20","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rules","Feature:Rule
Details","backport:prev-minor","v8.7.0","v8.8.0"],"number":150998,"url":"#150998
Solution] Get rid of rule description's fade in/out effect
(#150998)\n\n**Addresses:**
#150997
Summary\r\n\r\nIt removed rule details description's fade in and out
effect which was added by scrolling EUI
styles.\r\n\r\n*Before:*\r\n\r\n![Screenshot 2023-02-13 at 13 30
02](https://user-images.githubusercontent.com/3775283/218459498-28dd50ce-94eb-427f-865c-279f611b4049.png)\r\n\r\n![Screenshot
2023-02-13 at 13 30
11](https://user-images.githubusercontent.com/3775283/218459532-56072024-8e8b-4ee1-89be-ffece60d31a7.png)\r\n\r\n*After:*\r\n\r\n![Screenshot
2023-02-13 at 13 27
49](https://user-images.githubusercontent.com/3775283/218459699-8da6f5c3-e05d-4c9f-8122-392f3bfd6846.png)\r\n\r\n![Screenshot
2023-02-13 at 13 28
00](https://user-images.githubusercontent.com/3775283/218459735-1c522e19-573f-47c4-9490-5828373ac5ac.png)","sha":"de97462358fb859590693b1cca43c20b23f30c20"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150998","number":150998,"mergeCommit":{"message":"[Security
Solution] Get rid of rule description's fade in/out effect
(#150998)\n\n**Addresses:**
#150997
Summary\r\n\r\nIt removed rule details description's fade in and out
effect which was added by scrolling EUI
styles.\r\n\r\n*Before:*\r\n\r\n![Screenshot 2023-02-13 at 13 30
02](https://user-images.githubusercontent.com/3775283/218459498-28dd50ce-94eb-427f-865c-279f611b4049.png)\r\n\r\n![Screenshot
2023-02-13 at 13 30
11](https://user-images.githubusercontent.com/3775283/218459532-56072024-8e8b-4ee1-89be-ffece60d31a7.png)\r\n\r\n*After:*\r\n\r\n![Screenshot
2023-02-13 at 13 27
49](https://user-images.githubusercontent.com/3775283/218459699-8da6f5c3-e05d-4c9f-8122-392f3bfd6846.png)\r\n\r\n![Screenshot
2023-02-13 at 13 28
00](https://user-images.githubusercontent.com/3775283/218459735-1c522e19-573f-47c4-9490-5828373ac5ac.png)","sha":"de97462358fb859590693b1cca43c20b23f30c20"}}]}]
BACKPORT-->

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@spong spong mentioned this pull request Mar 7, 2023
Closed
@banderror banderror mentioned this pull request May 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

Assignees

@maximpn maximpn

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Rule Details Security Solution Detection Rule Details impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maximpn @elasticmachine @banderror @kibana-ci @kibanamachine