Render the correct form when edit extraction rules #151304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't fix the issue completely I believe. I managed to get 4 extraction rules that have same name and different field configurations this way. |
vidok
force-pushed
the
dmitrii/3995-render-edit-form
branch
from
5841636
to
a21f8cb
Compare
efegurkan
approved these changes
Feb 16, 2023
...nents/search_index/crawler/crawler_domain_detail/extraction_rules/extraction_rules_logic.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 16, 2023
Adjust Kea's reducers to render correct HTML forms (cherry picked from commit 1bba627)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 16, 2023
…151480) # Backport This will backport the following commits from `main` to `8.7`: - [Render the correct form when edit extraction rules (#151304)](#151304) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitriy Burlutskiy","email":"dmitrii.burlutckii@elastic.co"},"sourceCommit":{"committedDate":"2023-02-16T16:11:01Z","message":"Render the correct form when edit extraction rules (#151304)\n\nAdjust Kea's reducers to render correct HTML forms","sha":"1bba627926d944456da2a5189242162eb2a7ec59","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.7.0","v8.8.0"],"number":151304,"url":"#151304 the correct form when edit extraction rules (#151304)\n\nAdjust Kea's reducers to render correct HTML forms","sha":"1bba627926d944456da2a5189242162eb2a7ec59"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151304 the correct form when edit extraction rules (#151304)\n\nAdjust Kea's reducers to render correct HTML forms","sha":"1bba627926d944456da2a5189242162eb2a7ec59"}}]}] BACKPORT--> Co-authored-by: Dmitriy Burlutskiy <dmitrii.burlutckii@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/enterprise-search-team/issues/3934
Summary
The wrong form (
createinstead ofedit) is rendered when I try to modify an extraction rule.