[Security Solution][Exceptions] - Fix pagination bug on shared exception lists view #151393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nging number of rows displayed after page 1
yctercero
added
bug
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
yctercero
commented
Feb 16, 2023
| const onPerPageClick = useCallback((size: number) => { | ||
| closeRowSizePopover(); | ||
| setRowSize(size); | ||
| setActivePage(0); |
There was a problem hiding this comment.
This is where the fix is. There's some jank with the page, reloading when I don't think we need to on row selection, but for now just fixing this bug.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @yctercero |
nkhristinin
approved these changes
Feb 20, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2023
…ion lists view (elastic#151393) ## Summary Fixes elastic#147849 When changing number of rows in exception lists view from any page other than page 1. (cherry picked from commit 250dcff)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 22, 2023
…exception lists view (#151393) (#151927) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution][Exceptions] - Fix pagination bug on shared exception lists view (#151393)](#151393) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yara Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-22T18:55:11Z","message":"[Security Solution][Exceptions] - Fix pagination bug on shared exception lists view (#151393)\n\n## Summary\r\n\r\nFixes #147849 changing number of rows in exception lists view from any page other\r\nthan page 1.","sha":"250dcffcdab4a63411713d638185b0c1c7c84687","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Detections and Resp","Feature:Rule Exceptions","Team:Security Solution Platform","v8.7.0","v8.8.0"],"number":151393,"url":"#151393 Solution][Exceptions] - Fix pagination bug on shared exception lists view (#151393)\n\n## Summary\r\n\r\nFixes #147849 changing number of rows in exception lists view from any page other\r\nthan page 1.","sha":"250dcffcdab4a63411713d638185b0c1c7c84687"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151393 Solution][Exceptions] - Fix pagination bug on shared exception lists view (#151393)\n\n## Summary\r\n\r\nFixes #147849 changing number of rows in exception lists view from any page other\r\nthan page 1.","sha":"250dcffcdab4a63411713d638185b0c1c7c84687"}}]}] BACKPORT--> Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #147849
When changing number of rows in exception lists view from any page other than page 1.
Fix
bug_fix_147849.mov
Checklist