Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] - Fix bug mislabeling edit/delete for endpoint exception items #151532

Merged
merged 4 commits into from Feb 22, 2023

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Feb 16, 2023

Summary

Addresses #147607

Update text of edit/delete exception items to account for endpoint items vs non-endpoint items.

Updates

Rule exception item on lists management page

Screenshot 2023-02-16 at 3 27 23 PM

Endpoint exception item on lists management page

Screenshot 2023-02-16 at 3 27 52 PM

Rule exception item on rule management page

Screenshot 2023-02-16 at 3 30 15 PM

Endpoint exception item on rule management page

Screenshot 2023-02-16 at 3 29 55 PM

Checklist

@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:fix Feature:Rule Exceptions Security Solution Rule Exceptions feature Team:Security Solution Platform Security Solution Platform Team v8.7.0 labels Feb 16, 2023
@yctercero yctercero self-assigned this Feb 16, 2023
@yctercero yctercero requested a review from a team as a code owner February 16, 2023 23:39
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.9MB 13.9MB +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 41ff955 into elastic:main Feb 22, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2023
… endpoint exception items (elastic#151532)

## Summary

Addresses elastic#147607

Update text of edit/delete exception items to account for endpoint items
vs non-endpoint items.

(cherry picked from commit 41ff955)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@yctercero yctercero added the backport:prev-minor Backport to the previous minor version (i.e. one version back from main) label Feb 22, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2023
… endpoint exception items (elastic#151532)

## Summary

Addresses elastic#147607

Update text of edit/delete exception items to account for endpoint items
vs non-endpoint items.

(cherry picked from commit 41ff955)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 22, 2023
…te for endpoint exception items (#151532) (#151926)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Exceptions] - Fix bug mislabeling edit/delete for
endpoint exception items
(#151532)](#151532)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-22T18:51:30Z","message":"[Security
Solution][Exceptions] - Fix bug mislabeling edit/delete for endpoint
exception items (#151532)\n\n## Summary\r\n\r\nAddresses
#147607 text of
edit/delete exception items to account for endpoint items\r\nvs
non-endpoint
items.","sha":"41ff95523e832eb5cdcc01c233995446ab72969e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Rule
Exceptions","Team:Security Solution
Platform","v8.7.0","v8.8.0"],"number":151532,"url":"#151532
Solution][Exceptions] - Fix bug mislabeling edit/delete for endpoint
exception items (#151532)\n\n## Summary\r\n\r\nAddresses
#147607 text of
edit/delete exception items to account for endpoint items\r\nvs
non-endpoint
items.","sha":"41ff95523e832eb5cdcc01c233995446ab72969e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151532
Solution][Exceptions] - Fix bug mislabeling edit/delete for endpoint
exception items (#151532)\n\n## Summary\r\n\r\nAddresses
#147607 text of
edit/delete exception items to account for endpoint items\r\nvs
non-endpoint
items.","sha":"41ff95523e832eb5cdcc01c233995446ab72969e"}}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Rule Exceptions feature release_note:fix Team:Security Solution Platform Security Solution Platform Team v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants