[Fleet] agent_status total deprecated, added all and active #151564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
nchaulet
approved these changes
Feb 20, 2023
juliaElastic
added
release_note:deprecation
and removed
release_note:skip
|
@elastic/security-defend-workflows @kevinlog hey team, could someone review this from your side? It is a small change in Fleet API. |
dasansol92
reviewed
Feb 22, 2023
| @@ -25,6 +25,8 @@ export const initialPolicyDetailsState: () => Immutable<PolicyDetailsState> = () | |||
| online: 0, | |||
| total: 0, | |||
| other: 0, | |||
| all: 0, | |||
There was a problem hiding this comment.
Got a question, what about all the places where we already use the .total? Should we change all the .total references by .all? Or, is .total still working as before?
There was a problem hiding this comment.
yes, total still works as it is only deprecated, it should be changed eventually by the time the deprecation is removed (next major)
ashokaditya
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #135980
Marked
totaldeprecated in/agent_statusAPI response, instead addedall(all agents) andactive(all - inactive - unenrolled).Checklist