Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions] - Fix bug displaying filepath warning for non endpoint exception items #151570

Merged
merged 1 commit into from Feb 22, 2023
Merged

[Security Solution][Exceptions] - Fix bug displaying filepath warning for non endpoint exception items #151570

merged 1 commit into from Feb 22, 2023

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Feb 17, 2023 •
edited by kibanamachine

Summary

Addresses #145970

Fix bug displaying filepath warning for non endpoint exception items.

Fix (no warning text shown)

Screenshot 2023-02-16 at 4 44 22 PM

Checklist

@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Exceptions Security Solution Rule Exceptions feature Team:Security Solution Platform Security Solution Platform Team v8.7.0 labels Feb 17, 2023
@yctercero yctercero requested a review from a team as a code owner February 17, 2023 23:17
@yctercero yctercero self-assigned this Feb 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 152.5KB 152.6KB +20.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 7a03aea into elastic:main Feb 22, 2023
@kibanamachine kibanamachine mentioned this pull request Feb 22, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2023
@yctercero
[Security Solution][Exceptions] - Fix bug displaying filepath warning…
56b7a1d 
… for non endpoint exception items (elastic#151570)

## Summary

Addresses elastic#145970

Fix bug displaying filepath warning for non endpoint exception items

(cherry picked from commit 7a03aea)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@yctercero yctercero added the backport:prev-minor Backport to the previous minor version (i.e. one version back from main) label Feb 22, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 22, 2023
@yctercero
[Security Solution][Exceptions] - Fix bug displaying filepath warning…
7fe4b05 
… for non endpoint exception items (elastic#151570)

## Summary

Addresses elastic#145970

Fix bug displaying filepath warning for non endpoint exception items

(cherry picked from commit 7a03aea)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 22, 2023
@kibanamachine @yctercero
[8.7] [Security Solution][Exceptions] - Fix bug displaying filepath w…
12a539e 
…arning for non endpoint exception items (#151570) (#151928)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution][Exceptions] - Fix bug displaying filepath warning
for non endpoint exception items
(#151570)](#151570)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-22T18:56:59Z","message":"[Security
Solution][Exceptions] - Fix bug displaying filepath warning for non
endpoint exception items (#151570)\n\n## Summary\r\n\r\nAddresses
#145970 bug
displaying filepath warning for non endpoint exception
items","sha":"7a03aeaed93117e8ea5d881b7f822449aa2114e9","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:
SecuritySolution","Feature:Rule Exceptions","Team:Security Solution
Platform","v8.7.0","v8.8.0"],"number":151570,"url":"#151570
Solution][Exceptions] - Fix bug displaying filepath warning for non
endpoint exception items (#151570)\n\n## Summary\r\n\r\nAddresses
#145970 bug
displaying filepath warning for non endpoint exception
items","sha":"7a03aeaed93117e8ea5d881b7f822449aa2114e9"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#151570
Solution][Exceptions] - Fix bug displaying filepath warning for non
endpoint exception items (#151570)\n\n## Summary\r\n\r\nAddresses
#145970 bug
displaying filepath warning for non endpoint exception
items","sha":"7a03aeaed93117e8ea5d881b7f822449aa2114e9"}}]}] BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhristinin nkhristinin nkhristinin approved these changes

Assignees

@yctercero yctercero

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Rule Exceptions feature release_note:fix Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yctercero @elasticmachine @kibana-ci @kibanamachine @nkhristinin