Migrate reporting FTRs from the Stats Usage API
#151808
Conversation
afharo
added
Team:Core
afharo
added
the
(Deprecated) Feature:Reporting
afharo
force-pushed
the
migrate-reporting-ftrs-to-actual-telemetry-endpoint
branch
from
bf7834b
to
0654211
Compare
| async function getTelemetryStats(payload: { | ||
| unencrypted: true; | ||
| refreshCache?: boolean; | ||
| }): Promise<Array<{ clusterUuid: string; stats: UsageStatsPayload }>>; | ||
| async function getTelemetryStats(payload: { | ||
| unencrypted: false; | ||
| refreshCache?: boolean; | ||
| }): Promise<Array<{ clusterUuid: string; stats: string }>>; |
There was a problem hiding this comment.
adding these overrides to make it easier to consumers to deal with the output data.
| /** | ||
| * Public stats API: it returns the usage in camelCase format | ||
| */ | ||
| async getUsageStats() { | ||
| const { body } = await supertest | ||
| .get('/api/stats?extended=true') | ||
| .set('kbn-xsrf', 'xxx') | ||
| .expect(200); | ||
| return body.usage; | ||
| }, |
There was a problem hiding this comment.
Removing the API as it not recommended for its use to fetch usage.
afharo
force-pushed
the
migrate-reporting-ftrs-to-actual-telemetry-endpoint
branch
from
0654211
to
c418438
Compare
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
| @@ -35,10 +36,11 @@ export default function ({ getService }: FtrProviderContext) { | |||
| describe('server', function () { | |||
| this.tags('skipCloud'); | |||
| it('configuration settings of the tests_server', async () => { | |||
| const usage = await usageAPI.getUsageStats(); | |||
There was a problem hiding this comment.
I wonder if this will help resolve #134517
There was a problem hiding this comment.
I tried unskipping it, but it was still flaky. I can try to debug it on a follow up PR. I wouldn't like to delay this one further because it's blocking a community PR 🧡
| stack_stats: object; | ||
| // Needed for testing to make fields easier to access | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| stack_stats: Record<string, any>; |
There was a problem hiding this comment.
any is a footgun, if we want to use it to avoid real types I think we should rather cast to any in the test. Even if it means we're having to repeat it a bit more.
There was a problem hiding this comment.
I see your point! I reverted this change and specified this test-friendlier type in the FTR helper in 4c813a5 (#151808)
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
afharo
deleted the
migrate-reporting-ftrs-to-actual-telemetry-endpoint
branch
Summary
Part of #150429. To unblock #151082 we need to migrate the
reportingFTRs away from the deprecated Stats API to use the actual telemetry API.Checklist
For maintainers