Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner #151869

Merged
merged 1 commit into from Mar 6, 2023
Merged

[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner #151869

merged 1 commit into from Mar 6, 2023

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Feb 22, 2023 •
edited by kibanamachine

Summary

Issue #151262

These changes fixes broken empty preview results state on smaller screens.

Bug:

Screenshot 2023-02-22 at 15 24 06

Fix:

Screenshot 2023-02-22 at 15 23 25

@e40pud e40pud added release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Alerts Security Detection Alerts Area Team backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Feb 22, 2023
@e40pud e40pud requested a review from a team as a code owner February 22, 2023 14:26
@e40pud e40pud self-assigned this Feb 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.8MB 13.8MB -196.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

michaelolo24
michaelolo24 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@e40pud e40pud merged commit 1f21d36 into elastic:main Mar 6, 2023
@kibanamachine kibanamachine mentioned this pull request Mar 6, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 6, 2023
@e40pud
[Security Solution]Rule preview when returns zero value it overlaps t…
cd52be8 
…he No results match your search criteria banner (elastic#151869)

## Summary

Issue elastic#151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">

(cherry picked from commit 1f21d36)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 6, 2023
@kibanamachine @e40pud
[8.7] [Security Solution]Rule preview when returns zero value it over…
e88e7ed 
…laps the No results match your search criteria banner (#151869) (#152728)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution]Rule preview when returns zero value it overlaps
the No results match your search criteria banner
(#151869)](#151869)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2023-03-06T15:28:04Z","message":"[Security
Solution]Rule preview when returns zero value it overlaps the No results
match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue
#151262\r\n\r\nThese changes fixes broken empty preview results state on
smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\"
alt=\"Screenshot 2023-02-22 at 15 24
06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img
width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23
25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Alerts","backport:prev-minor","v8.8.0"],"number":151869,"url":"#151869
Solution]Rule preview when returns zero value it overlaps the No results
match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue
#151262\r\n\r\nThese changes fixes broken empty preview results state on
smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\"
alt=\"Screenshot 2023-02-22 at 15 24
06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img
width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23
25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151869","number":151869,"mergeCommit":{"message":"[Security
Solution]Rule preview when returns zero value it overlaps the No results
match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue
#151262\r\n\r\nThese changes fixes broken empty preview results state on
smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\"
alt=\"Screenshot 2023-02-22 at 15 24
06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img
width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23
25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
sloanelybutsurely pushed a commit to sloanelybutsurely/kibana that referenced this pull request Mar 8, 2023
@e40pud
[Security Solution]Rule preview when returns zero value it overlaps t…
70ac1ca 
…he No results match your search criteria banner (elastic#151869)

## Summary

Issue elastic#151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
@e40pud @bmorelli25
[Security Solution]Rule preview when returns zero value it overlaps t…
672b173 
…he No results match your search criteria banner (elastic#151869)

## Summary

Issue elastic#151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">
nkhristinin pushed a commit that referenced this pull request Mar 22, 2023
@e40pud @nkhristinin
[Security Solution]Rule preview when returns zero value it overlaps t…
7bcdd42 
…he No results match your search criteria banner (#151869)

## Summary

Issue #151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:fix Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@e40pud @elasticmachine @kibana-ci @kibanamachine @michaelolo24