Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Fixes terms aggregation support in wizard. #151879

Merged
merged 9 commits into from
Feb 24, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Feb 22, 2023

Summary

Fixes #147419.

The mapping to allow aggregating with the terms aggregation was missing on some field types.
This PR fixes the mapping to be in line with the field support defined in ES docs (https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-terms-aggregation.html)

Checklist

@walterra walterra self-assigned this Feb 22, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 370.7KB 370.8KB +35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra marked this pull request as ready for review February 23, 2023 15:03
@walterra walterra requested a review from a team as a code owner February 23, 2023 15:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895
Copy link
Member

qn895 commented Feb 23, 2023

LGTM 🎉

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@walterra walterra merged commit ee3e5eb into elastic:main Feb 24, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 24, 2023
@walterra walterra deleted the 147419-transform-terms-support branch February 24, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Transforms ML transforms :ml release_note:fix v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Transforms UI only allows "histogram" on long fields - should also allow "terms"
6 participants