Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Remove beta tag from process ancestry insight component #152011

Merged

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented Feb 23, 2023

Summary

PR just removes the beta badge from the ancestry insight part of the alert flyout component. No change in functionality.
whatev
image

@kqualters-elastic kqualters-elastic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.7.0 labels Feb 23, 2023
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner February 23, 2023 16:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.8MB 13.8MB -516.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like your both screenshots are from after the change i.e. removal of beta badge.

@kqualters-elastic kqualters-elastic merged commit 74fa43e into elastic:main Feb 27, 2023
@kqualters-elastic kqualters-elastic deleted the remove-beta-tag-ancestry branch February 27, 2023 16:02
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 27, 2023
…ponent (elastic#152011)

## Summary

PR just removes the beta badge from the ancestry insight part of the
alert flyout component. No change in functionality.
<img width="575" alt="whatev"
src="https://user-images.githubusercontent.com/56408403/220963002-b9ccddb6-b195-4571-90eb-de741ab030d9.png">
<img width="597" alt="image"
src="https://user-images.githubusercontent.com/56408403/220963149-fb379ed4-20a1-4480-9190-e307654126d7.png">

(cherry picked from commit 74fa43e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 27, 2023
…ht component (#152011) (#152242)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Remove beta tag from process ancestry insight
component (#152011)](#152011)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Qualters","email":"56408403+kqualters-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-02-27T16:02:18Z","message":"[Security
Solution] Remove beta tag from process ancestry insight component
(#152011)\n\n## Summary\r\n\r\nPR just removes the beta badge from the
ancestry insight part of the\r\nalert flyout component. No change in
functionality.\r\n<img width=\"575\"
alt=\"whatev\"\r\nsrc=\"https://user-images.githubusercontent.com/56408403/220963002-b9ccddb6-b195-4571-90eb-de741ab030d9.png\">\r\n<img
width=\"597\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/56408403/220963149-fb379ed4-20a1-4480-9190-e307654126d7.png\">","sha":"74fa43e5e4b3d0fcdfc9b1178aea5f5c5dc6eb2e","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting:Investigations","v8.7.0","v8.8.0"],"number":152011,"url":"#152011
Solution] Remove beta tag from process ancestry insight component
(#152011)\n\n## Summary\r\n\r\nPR just removes the beta badge from the
ancestry insight part of the\r\nalert flyout component. No change in
functionality.\r\n<img width=\"575\"
alt=\"whatev\"\r\nsrc=\"https://user-images.githubusercontent.com/56408403/220963002-b9ccddb6-b195-4571-90eb-de741ab030d9.png\">\r\n<img
width=\"597\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/56408403/220963149-fb379ed4-20a1-4480-9190-e307654126d7.png\">","sha":"74fa43e5e4b3d0fcdfc9b1178aea5f5c5dc6eb2e"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152011","number":152011,"mergeCommit":{"message":"[Security
Solution] Remove beta tag from process ancestry insight component
(#152011)\n\n## Summary\r\n\r\nPR just removes the beta badge from the
ancestry insight part of the\r\nalert flyout component. No change in
functionality.\r\n<img width=\"575\"
alt=\"whatev\"\r\nsrc=\"https://user-images.githubusercontent.com/56408403/220963002-b9ccddb6-b195-4571-90eb-de741ab030d9.png\">\r\n<img
width=\"597\"
alt=\"image\"\r\nsrc=\"https://user-images.githubusercontent.com/56408403/220963149-fb379ed4-20a1-4480-9190-e307654126d7.png\">","sha":"74fa43e5e4b3d0fcdfc9b1178aea5f5c5dc6eb2e"}}]}]
BACKPORT-->

Co-authored-by: Kevin Qualters <56408403+kqualters-elastic@users.noreply.github.com>
wwang500 pushed a commit to wwang500/kibana that referenced this pull request Feb 27, 2023
…ponent (elastic#152011)

## Summary

PR just removes the beta badge from the ancestry insight part of the
alert flyout component. No change in functionality.
<img width="575" alt="whatev"
src="https://user-images.githubusercontent.com/56408403/220963002-b9ccddb6-b195-4571-90eb-de741ab030d9.png">
<img width="597" alt="image"
src="https://user-images.githubusercontent.com/56408403/220963149-fb379ed4-20a1-4480-9190-e307654126d7.png">
@michaelolo24 michaelolo24 added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Mar 7, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
…ponent (elastic#152011)

## Summary

PR just removes the beta badge from the ancestry insight part of the
alert flyout component. No change in functionality.
<img width="575" alt="whatev"
src="https://user-images.githubusercontent.com/56408403/220963002-b9ccddb6-b195-4571-90eb-de741ab030d9.png">
<img width="597" alt="image"
src="https://user-images.githubusercontent.com/56408403/220963149-fb379ed4-20a1-4480-9190-e307654126d7.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants