Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Change agent reassign API from PUT to POST #152236

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Feb 27, 2023

Closes #136805

Summary

Change agents/{agentId}/reassign API from PUT to POST to make it consistent with other APIs on agent actions

As part of this task I'm marking as deprecated the PUT endpoint and updating the openApi docs

Checklist

@criamico criamico self-assigned this Feb 27, 2023
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 release_note:feature Makes this part of the condensed release notes release_note:deprecation and removed release_note:feature Makes this part of the condensed release notes labels Feb 27, 2023
@criamico criamico marked this pull request as ready for review February 27, 2023 15:29
@criamico criamico requested a review from a team as a code owner February 27, 2023 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 125.0KB 125.1KB +1.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
fleet 50 51 +1
securitySolution 428 430 +2
total +3

Total ESLint disabled count

id before after diff
fleet 60 61 +1
securitySolution 506 508 +2
total +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 17e41eb into elastic:main Feb 27, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 27, 2023
@criamico criamico deleted the 136805_modify_reassign_api branch February 27, 2023 16:50
wwang500 pushed a commit to wwang500/kibana that referenced this pull request Feb 27, 2023
Closes elastic#136805

## Summary
Change `agents/{agentId}/reassign` API from `PUT` to `POST` to make it
consistent with other APIs on agent actions

As part of this task I'm marking as deprecated the PUT endpoint and
updating the openApi docs


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
Closes elastic#136805

## Summary
Change `agents/{agentId}/reassign` API from `PUT` to `POST` to make it
consistent with other APIs on agent actions

As part of this task I'm marking as deprecated the PUT endpoint and
updating the openApi docs


### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:deprecation Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Change agent action APIs to PUT instead of POST
5 participants