Give access to angular $injector via chrome #15267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Team:Core
rhoboat
reviewed
Nov 30, 2017
| } | ||
|
|
||
| /** | ||
| * This method compines setupInjectorStub and teardownInjectorStub in one method. |
kimjoar
approved these changes
Nov 30, 2017
| @@ -0,0 +1,44 @@ | |||
| /** | |||
| * This test file contains stubs for chrome.getActiveInjector, that you will | |||
There was a problem hiding this comment.
getActiveInjector -> dangerouslyGetActiveInjector
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Nov 30, 2017
* Implement getActiveInjector * Fix typo in comments * Rename method to sound more frightening * Move test utils * Add more documentation * Fix typo in comment * Fix name of method in comments
timroes
added a commit
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API to the
chrome, that will give access to the current active Angular $injector, so you can inject Angular services into non Angular related code. This is e.g. done by the visualize loader. Since we are not able to always strip out Angular from the bottom-up, which wouldn't require this, and we already introduced the API (via a Webinar) after some discussion with @spalger we decided to rather create an APi in the chrome for it, but make clear from it's documentation, that you must be aware what you're doing when using Angular services outside of Angular.Technical details
This method uses the
.injector()method provided by Angular on any scoped element ondocument.body(the same element we bootstrap to). We also wait for bootstrap to run for the casegetActiveInjectorwould be called before the bootstraping starts.Since we are using the chrome everywhere in Kibana to render the base structure, this will be available from wherever you will call it.
There is just one exception though: Within tests, we don't actually bootstrap the application, but mock the modules. For this case, I've created a fixtures module, which you can use in any test - after you called
ngMock.module('kibana')to stub this method, by returning the$injector, that we got viangMock.injectinstead. I am working on another PR that uses this, and it solved all the testing issues.