Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Click on series in stacked chart opens traces view #153325

Merged

Conversation

cauemarcondes
Copy link
Contributor

In the Threads view when the user clicks on one of the stacked bar it navigates to the Traces view filtering the result based on the category.

go.to.traces.mov

@cauemarcondes
Copy link
Contributor Author

@thomasdullien I limited the click functionality to the chart that is shown in the Threads view only.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
profiling 127 128 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 262.9KB 263.2KB +310.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@inge4pres inge4pres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this off!
Looks good! 👍🏼
Nice job on adding the tests for the new case, much needed 🙏🏼

@iogbole what do you think?

@cauemarcondes cauemarcondes merged commit ba755f9 into elastic:main Mar 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 22, 2023
@cauemarcondes cauemarcondes deleted the profiling-filter-stackchart branch March 22, 2023 13:21
nkhristinin pushed a commit that referenced this pull request Mar 22, 2023
In the Threads view when the user clicks on one of the stacked bar it
navigates to the Traces view filtering the result based on the category.


https://user-images.githubusercontent.com/55978943/226430014-0fbeaad8-6ecb-4e34-a841-926ee2c8ddb9.mov
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Mar 22, 2023
…ic#153325)

In the Threads view when the user clicks on one of the stacked bar it
navigates to the Traces view filtering the result based on the category.


https://user-images.githubusercontent.com/55978943/226430014-0fbeaad8-6ecb-4e34-a841-926ee2c8ddb9.mov
@KOTungseth KOTungseth added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Observability Team label for Observability Team (for things that are handled across all of observability) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants