Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NA): external plugins development flow with the new modern package plugins in place #153562

Merged
merged 14 commits into from Apr 6, 2023

Conversation

mistic
Copy link
Member

@mistic mistic commented Mar 23, 2023

This PR fixes the 3rd party external plugin development workflow by introducing a dev step for plugins that allows for development usages of those with Kibana.

@github-actions
Copy link

Documentation preview:

@mistic mistic added chore Team:Operations Team label for Operations Team skipped-test release_note:skip Skip the PR/issue when compiling release notes v8.8.0 backport:skip This commit does not require backporting labels Apr 3, 2023
@mistic mistic marked this pull request as ready for review April 3, 2023 16:15
@mistic mistic requested a review from a team as a code owner April 3, 2023 16:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / context app context filters filter for presence should be addable via expanded data grid rows

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 66ac756 into elastic:main Apr 6, 2023
18 checks passed
@mistic
Copy link
Member Author

mistic commented May 11, 2023

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mistic added a commit to mistic/kibana that referenced this pull request May 11, 2023
…e plugins in place (elastic#153562)

This PR fixes the 3rd party external plugin development workflow by
introducing a dev step for plugins that allows for development usages of
those with Kibana.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 66ac756)
mistic added a commit that referenced this pull request May 11, 2023
…package plugins in place (#153562) (#157406)

# Backport

This will backport the following commits from `main` to `8.7`:
- [fix(NA): external plugins development flow with the new modern
package plugins in place
(#153562)](#153562)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago
Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2023-04-06T17:00:24Z","message":"fix(NA):
external plugins development flow with the new modern package plugins in
place (#153562)\n\nThis PR fixes the 3rd party external plugin
development workflow by\r\nintroducing a dev step for plugins that
allows for development usages of\r\nthose with
Kibana.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"66ac756b9897bd72e6f98834aaa0c3fac17d0585","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","skipped-test","release_note:skip","backport:skip","v8.8.0"],"number":153562,"url":"#153562:
external plugins development flow with the new modern package plugins in
place (#153562)\n\nThis PR fixes the 3rd party external plugin
development workflow by\r\nintroducing a dev step for plugins that
allows for development usages of\r\nthose with
Kibana.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"66ac756b9897bd72e6f98834aaa0c3fac17d0585"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"#153562:
external plugins development flow with the new modern package plugins in
place (#153562)\n\nThis PR fixes the 3rd party external plugin
development workflow by\r\nintroducing a dev step for plugins that
allows for development usages of\r\nthose with
Kibana.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"66ac756b9897bd72e6f98834aaa0c3fac17d0585"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Operations Team label for Operations Team v8.7.2 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants