[APM] Add transaction name filter in latency threshold rule #154241

kpatticha · 2023-04-03T12:58:02Z

Part of the #152329

Adds a synthrace scenario that generates many transactions per service
Fixes the duration chart preview when selecting All option - [APM] Chart preview in alert doesn't show data when transaction type is all #152195
Introduces the Transaction name filter in the rule type.

Pages loading the rule type

APM
Alert
Management rule

Consider

Update/Adding documentation example https://www.elastic.co/guide/en/kibana/master/apm-alerts.html#apm-create-transaction-alert

Creating a rule

Screen.Recording.2023-04-13.at.12.55.00.mov

Updating a rule

default.mov

Before

Screen.Recording.2023-04-13.at.13.16.17.mov

Notes

Feedback

The default action messages don't include any links. I will create a follow-up ticket to improve the messages with actionable links.

Related bugs but out of the scope of the PR

apmmachine · 2023-04-03T12:58:21Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

...ver/routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts

kpatticha · 2023-04-05T09:09:03Z

/oblt-deploy

…ansaction-name

kpatticha · 2023-04-11T08:15:04Z

/oblt-deploy

…ansaction-name

elasticmachine · 2023-04-13T11:19:34Z

Pinging @elastic/apm-ui (Team:APM)

…kibana into 152329-alert-transaction-name

kpatticha · 2023-04-19T13:50:16Z

The reason doesn't include the transaction name.

Avg. latency is 1,000 ms in the last 50 mins for synth-go-0. Alert when > 500 ms.

can be:
Avg latency for GET /orders/1 transaction is 1,000 ms in the last 50 minutes for synth-go-0

benakansara · 2023-04-19T14:12:07Z

The reason doesn't include the transaction name.

Avg. latency is 1,000 ms in the last 50 mins for synth-go-0. Alert when > 500 ms.

can be: Avg latency for GET /orders/1 transaction is 1,000 ms in the last 50 minutes for synth-go-0

@kpatticha I have updated reason message in this PR. The new reason message will be for example -
Avg. latency is 1,000 ms in the last 50 mins for synth-go-0, development, request, GET /orders. Alert when > 500 ms.

I have updated this for all 3 rules - Latency threshold, Failed transaction, Error count rules

benakansara · 2023-04-19T16:17:29Z

/oblt-deploy

…kibana into 152329-alert-transaction-name

kpatticha · 2023-04-19T18:12:42Z

@elasticmachine merge upstream

kpatticha · 2023-04-20T06:27:32Z

@elasticmachine merge upstream

kibana-ci · 2023-04-20T07:39:45Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.4MB	3.4MB	+2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	32.1KB	32.2KB	+69.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	394	397	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	474	477	+3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv · 2023-04-20T08:39:25Z

/oblt-deploy

dgieselaar · 2023-04-20T09:18:19Z

x-pack/test/apm_api_integration/tests/alerts/chart_preview.spec.ts

+        x: 1627974600000,
+        y: 18485.85714285714,


Ah, these are archives. We should replace it with Synthtrace at some point, but at least we capture the current value so we don't unintentionally change it.

We might be able to tackle it during test plan for 8.8. I've created an issue to capture this and the other tests that still rely on archives: #155359

sorenlouv · 2023-04-20T10:26:43Z

x-pack/plugins/apm/public/components/alerting/utils/fields.tsx

+
+  return (
+    <PopoverExpression value={currentValue || allOptionText} title={label}>
+      <SuggestionsSelect


We may want to sort the suggestions. Currently they are ordered by volume (afaict)

@sqren do you mean sort alphabetically? The suggestions dropdown uses _terms_enum API which I'm not 100% how it returns the results

Yes, I mean alphabetically. Sorting on the client is fine.

sorenlouv · 2023-04-20T10:28:51Z

The alert details page should show the transaction name when it's set similar to how we show service name and environment

@kpatticha will you create an issue for this?

kpatticha · 2023-04-20T10:41:23Z

similar to how we show service name and environment
good catch, created
#155364

#155405) part of #152329 related work #154241 Introduces the Transaction name filter in the failed transaction rate rule type https://user-images.githubusercontent.com/3369346/233386404-1875b283-0321-4bf1-a7d3-66327f7d4ec5.mov ## Fixes The regression introduces in a previous [PR](fce4ef8) Existing rule types can have empty string in their params so we need to make sure we don't filter empty values as it will yield no results. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…154241) Part of the elastic#152329 1. Adds a synthrace scenario that generates many transactions per service 2. Fixes the duration chart preview when selecting All option - elastic#152195 3. Introduces the `Transaction name` filter in the rule type. ### Pages loading the rule type 1. APM 2. Alert 3. Management rule ### Consider - [ ] Update/Adding documentation example https://www.elastic.co/guide/en/kibana/master/apm-alerts.html#apm-create-transaction-alert ## Creating a rule https://user-images.githubusercontent.com/3369346/231740745-425c8eb8-6798-4ce4-b375-4ef96afdb334.mov ## Updating a rule https://user-images.githubusercontent.com/3369346/231742035-28f50dfd-64bb-475d-b037-331eea4188d7.mov ### Before https://user-images.githubusercontent.com/3369346/232799038-2edaa199-b970-48f2-b3ca-728273e4bf44.mov ### Notes #### Feedback The default action messages don't include any links. I will create a follow-up ticket to improve the messages with actionable links. Related bugs but out of the scope of the PR - elastic#154818 - elastic#154704 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

elastic#155405) part of elastic#152329 related work elastic#154241 Introduces the Transaction name filter in the failed transaction rate rule type https://user-images.githubusercontent.com/3369346/233386404-1875b283-0321-4bf1-a7d3-66327f7d4ec5.mov ## Fixes The regression introduces in a previous [PR](elastic@fce4ef8) Existing rule types can have empty string in their params so we need to make sure we don't filter empty values as it will yield no results. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

[APM] Add transaction name as field latency alert

88328ef

dgieselaar reviewed Apr 5, 2023

View reviewed changes

...ver/routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts Outdated Show resolved Hide resolved

Remove transacation name from groupping

f5af7a5

kpatticha force-pushed the 152329-alert-transaction-name branch from b48c760 to f5af7a5 Compare April 6, 2023 11:05

Merge branch 'main' of github.com:elastic/kibana into 152329-alert-tr…

8f6b21d

…ansaction-name

kpatticha added 7 commits April 12, 2023 08:36

Add scenario with many transactions

8736534

Fix chart preview when selecting all option

7e23032

Pass transaction name

bd2eb26

Fix test and warnings

5581a7d

Merge branch 'main' of github.com:elastic/kibana into 152329-alert-tr…

48462ca

…ansaction-name

Merge branch 'main' of github.com:elastic/kibana into 152329-alert-tr…

f4d6d43

…ansaction-name

Chart preview api test

372df8e

kpatticha changed the title ~~[APM] Add transaction name as field latency alert~~ [APM] Add transaction name filter in latency threshold rule Apr 13, 2023

kpatticha marked this pull request as ready for review April 13, 2023 11:19

kpatticha requested a review from a team as a code owner April 13, 2023 11:19

Merge branch 'main' into 152329-alert-transaction-name

1497255

botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 13, 2023

kpatticha added v8.8.0 release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes and removed Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes labels Apr 13, 2023

kpatticha requested a review from a team April 13, 2023 11:21

kpatticha added 2 commits April 13, 2023 14:38

Fix transaction name

be32320

Merge branch '152329-alert-transaction-name' of github.com:kpatticha/…

e317916

…kibana into 152329-alert-transaction-name

botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 13, 2023

kpatticha added 2 commits April 19, 2023 18:56

Fix test

a8a39b2

Merge branch '152329-alert-transaction-name' of github.com:kpatticha/…

56c7d24

…kibana into 152329-alert-transaction-name

kpatticha force-pushed the 152329-alert-transaction-name branch from 10231f9 to 56c7d24 Compare April 19, 2023 17:51

Merge branch 'main' into 152329-alert-transaction-name

6f67b4a

Merge branch 'main' into 152329-alert-transaction-name

35e9f5f

dgieselaar reviewed Apr 20, 2023

View reviewed changes

dgieselaar approved these changes Apr 20, 2023

View reviewed changes

sorenlouv reviewed Apr 20, 2023

View reviewed changes

kpatticha mentioned this pull request Apr 20, 2023

Display transaction name info in alert details page #155364

Open

kpatticha merged commit 7c70508 into elastic:main Apr 20, 2023

kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023

This was referenced Apr 20, 2023

[APM] Add transaction name filter in failed transaction rate rule type #155405

Merged

[APM] Alerts for specific transaction groups and error groups #152329

Closed

kpatticha mentioned this pull request Apr 26, 2023

[REQUEST]: Document new functionality for APM alerts & rules elastic/observability-docs#2878

Closed

sorenlouv mentioned this pull request May 3, 2023

[APM] Support creating a failed transaction alerts at the individual transaction granularity #134481

Closed

kpatticha mentioned this pull request May 5, 2023

[APM] Chart preview in alert doesn't show data when transaction type is all #152195

Closed

gbamparop mentioned this pull request May 12, 2023

[APM] Add support for alert indicators in transaction groups #157483

Closed

sorenlouv mentioned this pull request Jun 8, 2023

[APM] Alerting use cases and examples #103785

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add transaction name filter in latency threshold rule #154241

[APM] Add transaction name filter in latency threshold rule #154241

kpatticha commented Apr 3, 2023 •

edited

Loading

apmmachine commented Apr 3, 2023

kpatticha commented Apr 5, 2023

kpatticha commented Apr 11, 2023

elasticmachine commented Apr 13, 2023

kpatticha commented Apr 19, 2023 •

edited

Loading

benakansara commented Apr 19, 2023

benakansara commented Apr 19, 2023

kpatticha commented Apr 19, 2023

kpatticha commented Apr 20, 2023

kibana-ci commented Apr 20, 2023

ESLint disabled line counts

Total ESLint disabled count

sorenlouv commented Apr 20, 2023

dgieselaar Apr 20, 2023

sorenlouv Apr 20, 2023

sorenlouv Apr 20, 2023

kpatticha Apr 20, 2023

sorenlouv Apr 21, 2023

sorenlouv commented Apr 20, 2023

kpatticha commented Apr 20, 2023

[APM] Add transaction name filter in latency threshold rule #154241

[APM] Add transaction name filter in latency threshold rule #154241

Conversation

kpatticha commented Apr 3, 2023 • edited Loading

Pages loading the rule type

Consider

Creating a rule

Updating a rule

Before

Notes

Feedback

apmmachine commented Apr 3, 2023

🤖 GitHub comments

kpatticha commented Apr 5, 2023

kpatticha commented Apr 11, 2023

elasticmachine commented Apr 13, 2023

kpatticha commented Apr 19, 2023 • edited Loading

benakansara commented Apr 19, 2023

benakansara commented Apr 19, 2023

kpatticha commented Apr 19, 2023

kpatticha commented Apr 20, 2023

kibana-ci commented Apr 20, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

sorenlouv commented Apr 20, 2023

dgieselaar Apr 20, 2023

Choose a reason for hiding this comment

sorenlouv Apr 20, 2023

Choose a reason for hiding this comment

sorenlouv Apr 20, 2023

Choose a reason for hiding this comment

kpatticha Apr 20, 2023

Choose a reason for hiding this comment

sorenlouv Apr 21, 2023

Choose a reason for hiding this comment

sorenlouv commented Apr 20, 2023

kpatticha commented Apr 20, 2023

kpatticha commented Apr 3, 2023 •

edited

Loading

kpatticha commented Apr 19, 2023 •

edited

Loading